Skip to content

test new solver on CI until stabilization#156146

Open
lqd wants to merge 3 commits into
rust-lang:mainfrom
lqd:new-solver-ci-std
Open

test new solver on CI until stabilization#156146
lqd wants to merge 3 commits into
rust-lang:mainfrom
lqd:new-solver-ci-std

Conversation

@lqd
Copy link
Copy Markdown
Member

@lqd lqd commented May 4, 2026

We need the new solver to be able to build the stdlib, and this has regressed in the recent past. Things are broken right now, and we want to ensure this keeps working until stabilization later this year.

I've added this to the x86_64-gnu-llvm-XX job (note no -1/2/3 suffix) so it's run on PR and auto CI, and because it's roughly the fastest of these builders, though maybe the aarch64 llvm 1 and 2 are slightly faster.

Building the stage 1 ./x build library/ is generally quite quick, a couple minutes at most.

The new solver fix to build std is from @lcnr on zulip.
r? @marcoieni

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 4, 2026
@lqd
Copy link
Copy Markdown
Member Author

lqd commented May 4, 2026

Things are currently broken, the job should fail if this is working.

@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label May 4, 2026
#
# This is intended to make sure that both `--pass=check` continues to
# work.
# Run the UI test suite in `--pass=check` mode, to ensure it continues to work.
Copy link
Copy Markdown
Member Author

@lqd lqd May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing this comment made me realize running the mir-opt tests and --pass=check is duplicated in this job and in the llvm-2 jobs here

# Run the `mir-opt` tests again but this time for a 32-bit target.
# This enforces that tests using `// EMIT_MIR_FOR_EACH_BIT_WIDTH` have
# both 32-bit and 64-bit outputs updated by the PR author, before
# the PR is approved and tested for merging.
# It will also detect tests lacking `// EMIT_MIR_FOR_EACH_BIT_WIDTH`,
# despite having different output on 32-bit vs 64-bit targets.
../x --stage 2 test tests/mir-opt --host='' --target=i686-unknown-linux-gnu
# Run the UI test suite again, but in `--pass=check` mode
#
# This is intended to make sure that both `--pass=check` continues to
# work.
../x.ps1 --stage 2 test tests/ui --pass=check --host='' --target=i686-unknown-linux-gnu

So we could slightly optimize either job by removing these two tasks. I could also do that in another PR if you want?

View changes since the review

@lqd lqd marked this pull request as ready for review May 7, 2026 09:47
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 7, 2026
@rust-bors

This comment was marked as resolved.

lqd added 3 commits May 8, 2026 20:59
We need it to be able to build the stdlib, and this has regressed
in the recent past.
@lqd lqd force-pushed the new-solver-ci-std branch from aab502c to f243f57 Compare May 8, 2026 19:06
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 8, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@lqd
Copy link
Copy Markdown
Member Author

lqd commented May 8, 2026

Rebased to fix conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants