test new solver on CI until stabilization#156146
Open
lqd wants to merge 3 commits into
Open
Conversation
Member
Author
|
Things are currently broken, the job should fail if this is working. |
This comment has been minimized.
This comment has been minimized.
lqd
commented
May 7, 2026
| # | ||
| # This is intended to make sure that both `--pass=check` continues to | ||
| # work. | ||
| # Run the UI test suite in `--pass=check` mode, to ensure it continues to work. |
Member
Author
There was a problem hiding this comment.
Fixing this comment made me realize running the mir-opt tests and --pass=check is duplicated in this job and in the llvm-2 jobs here
rust/src/ci/docker/scripts/x86_64-gnu-llvm2.sh
Lines 9 to 21 in 0e5924a
So we could slightly optimize either job by removing these two tasks. I could also do that in another PR if you want?
This comment was marked as resolved.
This comment was marked as resolved.
We need it to be able to build the stdlib, and this has regressed in the recent past.
this is lcnr's solution
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
Rebased to fix conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need the new solver to be able to build the stdlib, and this has regressed in the recent past. Things are broken right now, and we want to ensure this keeps working until stabilization later this year.
I've added this to the
x86_64-gnu-llvm-XXjob (note no-1/2/3suffix) so it's run on PR and auto CI, and because it's roughly the fastest of these builders, though maybe the aarch64 llvm 1 and 2 are slightly faster.Building the stage 1
./x build library/is generally quite quick, a couple minutes at most.The new solver fix to build std is from @lcnr on zulip.
r? @marcoieni