Pass the whole GenericArgs to Interner::for_each_relevant_impl()#156295
Pass the whole GenericArgs to Interner::for_each_relevant_impl()#156295ChayimFriedman2 wants to merge 1 commit intorust-lang:mainfrom
GenericArgs to Interner::for_each_relevant_impl()#156295Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pass the whole `GenericArgs` to `Interner::for_each_relevant_impl()`
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (f3ca1e1): comparison URL. Overall result: ❌✅ regressions and improvements - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 3.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 497.449s -> 499.373s (0.39%) |
This comment has been minimized.
This comment has been minimized.
And not just the self type. rustc does not make use of this, but rust-analyzer needs it to support impls in the same block as args, see https://rust-lang.zulipchat.com/#narrow/channel/144729-t-types/topic/non.20local.20impls.20for.20generic.20args/with/593629693. I'm not entirely sure this covers all cases (e.g. an unnormalized alias), and wants feedback from a types team member.
c9f8bab to
41cb440
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Pass the whole
GenericArgstoInterner::for_each_relevant_impl()And not just the self type.
rustc does not make use of this, but rust-analyzer needs it to support impls in the same block as args, see https://rust-lang.zulipchat.com/#narrow/channel/144729-t-types/topic/non.20local.20impls.20for.20generic.20args/with/593629693.
I'm not entirely sure this covers all cases (e.g. an unnormalized alias), and want feedback from a types team member.
r? types