Rollup of 13 pull requests#156681
Merged
Merged
Conversation
The definition did not match the one from PartialEq and was merged with the definition of symmetry.
`cc()` gets target flags, which won't match with the host triple used by `bare_rustc()`.
In the future this can be used by build-std, but until then it is still useful for allowing rust-analyzer to work offline. This increases the unpacked size by 24MB (from 116MB to 140MB) and the compressed size by only 2MB (from 18MB to 20MB)
There is no reference to `char` in c_short.md
The documentation for the `format_into` methods on unsigned integers still said "in signed decimal format". Change them to say "unsigned".
…acrum Include vendored sources in the rust-src component In the future this can be used by build-std, but until then it is still useful for allowing rust-analyzer to work offline. This increases the unpacked size by 24MB (from 116MB to 140MB) and the compressed size by only 2MB (from 18MB to 20MB)
Fix cross-compiling `macos-deployment-target-warning` test `cc()` gets target flags, which won't match with the host triple used by `bare_rustc()`. Follow-up to rust-lang#155716, with both of these, `./x test --target arm64e-apple-darwin tests` now succeeds. r? compiler
remove/update various cfg(miri) I went over all `cfg(miri)` in `library/`. Most of the things I noticed have become separate PRs; these here are the few remaining scattered little fixes in various places.
…end-span, r=chenyukang Preserve spans when hiding do_not_recommend impls Fixes rust-lang#156475 by restoring the root span only when the current refined span has wandered outside the parent obligation.
doc(core::cmp::Eq): fix definition of symmetry The definition did not match the one from PartialEq
…xed_array, r=SimonSapin implement `into_array` for `Vec<T>` for more into_array coverage and to avoid harmful obtuse opaque try_into calls
Fix missing period in Iterator product doc comment It looks like the other doc comments all end with a period.
std: replace "safe" with "sound" in safety documentation - `env::set_var` - `env::remove_var` Context: rust-lang#124636
…Sapin c ffi document fixes for c_short.md There is no reference to `char` in c_short.md
…imonSapin library: Fix std compilation for espidf target in unix::process Fixes a regression on the riscv32imac-esp-espidf target caused by commit 7bf5fe7 (linked issue rust-lang#156537) . The unix_kill_process_group feature attempts to use libc::SIGKILL, which is not supported on the espidf target. Discussed in `esp-idf-sys` issue: esp-rs/esp-idf-sys#419
…monSapin Change division to multiplication in floating-point midpoint Multiplication is faster than division on most (all?) platforms. While the optimizer will handle this, there is really no point in relying on that. Using multiplication directly will not have any drawbacks and are numerically identical (in this case since 1.0 / 2.0 == 0.5) Consider the examples at https://godbolt.org/z/oMvb9vobG where it is clear that the non-optimized version uses division, while the optimized version uses multiplication.
…imonSapin Fix typo in `format_into` docs: signed -> unsigned The documentation for the `format_into` methods on unsigned integers still said "in signed decimal format". Change them to say "unsigned".
change `other uses of const` to `raw pointers` in const keyword docs this section only talks about how `const` is used in raw pointers and doesn't give any other uses, so in my opinion it would be a bit clearer if the section was named `raw pointers` or something similar.
rustbot
added
O-unix
Contributor
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 18, 2026
Rollup of 13 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing b40ce8b (parent) -> a31c27a (this PR) Test differencesShow 476 test diffsStage 1
Stage 2
Additionally, 474 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a31c27a887b40df16ab9dfb8c9f7924636092509 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: b40ce8b786 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (a31c27a): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 511.409s -> 510.693s (-0.14%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
macos-deployment-target-warningtest #155870 (Fix cross-compilingmacos-deployment-target-warningtest)into_arrayforVec<T>#156234 (implementinto_arrayforVec<T>)format_intodocs: signed -> unsigned #156668 (Fix typo informat_intodocs: signed -> unsigned)other uses of consttoraw pointersin const keyword docs #156677 (changeother uses of consttoraw pointersin const keyword docs)r? @ghost
Create a similar rollup