Add #[inline] back on __getit (fixes #25088)

[nox]

No description provided.

[rust-highfive]

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

[eddyb]

@bors r+ (let's see if it passes on windows)

[bors]

📌 Commit 89f3970 has been approved by eddyb

[kennytm]

The rollup #50275 failed on x86_64-msvc with an access violation when trying to learn about target-specific information using the stage1 rustc:

Building stage1 std artifacts (x86_64-pc-windows-msvc -> x86_64-pc-windows-msvc)
error: failed to run `rustc` to learn about target-specific information
Caused by:
  process didn't exit successfully: `C:\projects\rust\build\bootstrap/debug/rustc - --crate-name ___ --print=file-names --target x86_64-pc-windows-msvc --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro` (exit code: 3221225477)

Given the previous test result, I think this PR is the cause.

[eddyb]

@kennytm Sorry, this should have been excluded from rollup, because we were checking for that failure - is there any way for someone to indicate that a PR is "standalone" yet?

[nox]

is there any way for someone to indicate that a PR is "standalone" yet?

"(Do not merge)" as a prefix of the PR title would probably signal that this shouldn't go in a rollup.

[eddyb]

@nox [WIP] prefix doesn't even let you r+ it. But we want merging, just not rollup.

[alexcrichton]

If this is claiming to fix #25088 can a codegen test be added to assert such functionality? This has historically been very finnicky and easy to regress.

[bors]

⌛ Testing commit 89f3970 with merge ed3ce2ec4df3acb3efcec3d97a0a9876f6aadcf2...

[bors]

💔 Test failed - status-appveyor

[kennytm]

Same error as #50252 (comment).

@bors r-

[shepmaster]

Ping from triage, @nox ! Will you have time to address the review comments?

I don't believe that fixes #25088 in the PR title works, but I've never tried, honestly. I always put it in the body... Huh TIL.

[emilyalbini]

Thank you for this PR @nox! Unfortunately we haven't heard from you on this in a while, so I'm closing the PR to keep things tidy. Don't worry though, if you'll have time again in the future please reopen this PR, we'll be happy to review it again!