Stabilise exhaustive integer patterns by varkor · Pull Request #56362 · rust-lang/rust

varkor · 2018-11-30T00:46:23Z

Edit: This was merged in #56557. This now just contains a fix for 16-bit pointer sizes.

This is dependent on the FCP for rust-lang/rfcs#2591 being completed, but that should happen tomorrow, so there's little harm in opening this PR early.

Closes #50907.

rust-highfive · 2018-11-30T00:46:27Z

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

src/test/run-pass/array-slice-vec/vec-matching-autoslice.stderr

src/test/run-pass/binding/match-range.stderr

src/test/run-pass/issues/issue-15881-model-lexer-dotdotdot.stderr

src/test/run-pass/issues/issue-7222.stderr

src/test/ui/consts/const-pattern-irrefutable.rs

src/test/ui/exhaustive_integer_patterns.rs

src/test/ui/match/match-range-fail-dominate.stderr

varkor · 2018-11-30T16:19:55Z

@Centril: I think you're right; there's a bug with the handling of floating-point numbers here. I'll look into it and add another test case.

Centril · 2018-11-30T16:59:14Z

@varkor For completeness I'd also include a test case that shows that removing the _ => ... actually errors in addition to the one showing that the lint doesn't fire.

src/test/ui/refutable-pattern-errors.stderr

Centril

Looks great <3.

Centril · 2018-12-01T14:28:42Z

@estebank Are we happy with the PR?

eddyb · 2018-12-02T16:44:40Z

src/librustc/ty/sty.rs

        }
    }

+    pub fn is_pointer_sized(&self) -> bool {


This name doesn't feel ideal. I'd rather have is_target_agnostic_primitive that return true only for non-{u,i}size integer types, char and floating-point types.

It seems like reversing the sense of this function would complicate some of the tests below, in particular the one that checks (is_pointer_sized() && !feature.pointer_sized) or whatever. I think the function is ok "as is" though. I mean the isize and usize pattern are meant (I think) to evoke the "native size" of a pointer. I might prefer is_pointer_sized_int though, just to be a bit more specific (is_target_dependent_int would be ok too but feels less obvious to me).

Yes, the function is used explicitly for the pointer-sized integers, so making it more general would obfuscate the uses. I can make the name a bit more descriptive as suggested, though.

eddyb · 2018-12-02T16:47:20Z

r? @nikomatsakis

estebank · 2018-12-03T18:09:36Z

@Centril LGTM++, but I'll defer to niko's review.

nikomatsakis

r=me -- not sure how much @eddyb cares about the name of is_pointer_sized though

nikomatsakis · 2018-12-04T14:46:15Z

@bors r+

bors · 2018-12-04T14:46:16Z

📌 Commit 4406391 has been approved by nikomatsakis

varkor · 2018-12-06T14:35:43Z

@bors r=nikomatsakis

bors · 2018-12-06T14:35:44Z

📌 Commit 5be3f0e001f7e3e88fe4f19d173a1fd5fca18142 has been approved by nikomatsakis

bors · 2018-12-06T15:07:29Z

☔ The latest upstream changes (presumably #56557) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive · 2018-12-06T15:24:12Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:00e1128a:start=1544106980825711898,finish=1544107035779812663,duration=54954100765
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:45:50] .................................................................................................... 3500/5123
[00:45:53] ...........................ii....................................................................... 3600/5123
[00:45:55] .............................................i...................................................... 3700/5123
[00:45:56] .................................................................................................... 3800/5123
[00:45:57] .i.................................................................................................. 3900/5123
[00:46:02] ...........................F........................................................................ 4000/5123
[00:46:09] .................................................................................................... 4200/5123
[00:46:13] ................................................................................................i... 4300/5123
[00:46:17] .................................................................................................... 4400/5123
[00:46:21] .................................................................................................... 4500/5123
---
[00:46:39] 
[00:46:39] ---- [ui] ui/precise_pointer_size_matching.rs stdout ----
[00:46:39] diff of stderr:
[00:46:39] 
[00:46:39] 1 error[E0004]: non-exhaustive patterns: `$ISIZE_MIN..=-6isize` and `21isize..=$ISIZE_MAX` not covered
[00:46:39] +   --> $DIR/precise_pointer_size_matching.rs:27:11
[00:46:39] 3    |
[00:46:39] 3    |
[00:46:39] 4 LL |     match 0isize { //~ ERROR non-exhaustive patterns
[00:46:39] 5    |           ^^^^^^ patterns `$ISIZE_MIN..=-6isize` and `21isize..=$ISIZE_MAX` not covered
[00:46:39] 6 
[00:46:39] 6 
[00:46:39] 7 error[E0004]: non-exhaustive patterns: `0usize` and `21usize..=$USIZE_MAX` not covered
[00:46:39] +   --> $DIR/precise_pointer_size_matching.rs:32:11
[00:46:39] 9    |
[00:46:39] 9    |
[00:46:39] 10 LL |     match 0usize { //~ ERROR non-exhaustive patterns
[00:46:39] 11    |           ^^^^^^ patterns `0usize` and `21usize..=$USIZE_MAX` not covered
[00:46:39] 
[00:46:39] The actual stderr differed from the expected stderr.
[00:46:39] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/precise_pointer_size_matching/precise_pointer_size_matching.stderr
[00:46:39] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/precise_pointer_size_matching/precise_pointer_size_matching.stderr
[00:46:39] To update references, rerun the tests and pass the `--bless` flag
[00:46:39] To only update this specific test, also pass `--test-args precise_pointer_size_matching.rs`
[00:46:39] error: 1 errors occurred comparing output.
[00:46:39] status: exit code: 1
[00:46:39] status: exit code: 1
[00:46:39] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/precise_pointer_size_matching.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/precise_pointer_size_matching/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/precise_pointer_size_matching/auxiliary" "-A" "unused"
[00:46:39] ------------------------------------------
[00:46:39] 
[00:46:39] ------------------------------------------
[00:46:39] stderr:
[00:46:39] stderr:
[00:46:39] ------------------------------------------
[00:46:39] {"message":"non-exhaustive patterns: `-9223372036854775808isize..=-6isize` and `21isize..=9223372036854775807isize` not covered","code":{"code":"E0004","explanation":"\nThis error indicates that the compiler cannot guarantee a matching pattern for\none or more possible inputs to a match expression. Guaranteed matches are\nrequired in order to assign values to match expressions, or alternatively,\ndetermine the flow of execution. Erroneous code example:\n\n```compile_fail,E0004\nenum Terminator {\n    HastaLaVistaBaby,\n    TalkToMyHand,\n}\n\nlet x = Terminator::HastaLaVistaBaby;\n\nmatch x { // error: non-exhaustive patterns: `HastaLaVistaBaby` not covered\n    Terminator::TalkToMyHand => {}\n}\n```\n\nIf you encounter this error you must alter your patterns so that every possible\nvalue of the input type is matched. For types with a small number of variants\n(like enums) you should probably cover all cases explicitly. Alternatively, the\nunderscore `_` wildcard pattern can be added after all other patterns to match\n\"anything else\". Example:\n\n```\nenum Terminator {\n    HastaLaVistaBaby,\n    TalkToMyHand,\n}\n\nlet x = Terminator::HastaLaVistaBaby;\n\nmatch x {\n    Terminator::TalkToMyHand => {}\n    Terminator::HastaLaVistaBaby => {}\n}\n\n// or:\n\nmatch x {\n    Terminator::TalkToMyHand => {}\n    _ => {}\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/precise_pointer_size_matching.rs","byte_start":871,"byte_end":877,"line_start":27,"line_end":27,"column_start":11,"column_end":17,"is_primary":true,"text":[{"text":"    match 0isize { //~ ERROR non-exhaustive patterns","highlight_start":11,"highlight_end":17}],"label":"patterns `-9223372036854775808isize..=-6isize` and `21isize..=9223372036854775807isize` not covered","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0004]: non-exhaustive patterns: `-9223372036854775808isize..=-6isize` and `21isize..=9223372036854775807isize` not covered\n  --> /checkout/src/test/ui/precise_pointer_size_matching.rs:27:11\n   |\nLL |     match 0isize { //~ ERROR non-exhaustive patterns\n   |           ^^^^^^ patterns `-9223372036854775808isize..=-6isize` and `21isize..=9223372036854775807isize` not covered\n\n"}
[00:46:39] {"message":"non-exhaustive patterns: `0usize` and `21usize..=18446744073709551615usize` not covered","code":{"code":"E0004","explanation":"\nThis error indicates that the compiler cannot guarantee a matching pattern for\none or more possible inputs to a match expression. Guaranteed matches are\nrequired in order to assign values to match expressions, or alternatively,\ndetermine the flow of execution. Erroneous code example:\n\n```compile_fail,E0004\nenum Terminator {\n    HastaLaVistaBaby,\n    TalkToMyHand,\n}\n\nlet x = Terminator::HastaLaVistaBaby;\n\nmatch x { // error: non-exhaustive patterns: `HastaLaVistaBaby` not covered\n    Terminator::TalkToMyHand => {}\n}\n```\n\nIf you encounter this error you must alter your patterns so that every possible\nvalue of the input type is matched. For types with a small number of variants\n(like enums) you should probably cover all cases explicitly. Alternatively, the\nunderscore `_` wildcard pattern can be added after all other patterns to match\n\"anything else\". Example:\n\n```\nenum Terminator {\n    HastaLaVistaBaby,\n    TalkToMyHand,\n}\n\nlet x = Terminator::HastaLaVistaBaby;\n\nmatch x {\n    Terminator::TalkToMyHand => {}\n    Terminator::HastaLaVistaBaby => {}\n}\n\n// or:\n\nmatch x {\n    Terminator::TalkToMyHand => {}\n    _ => {}\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/precise_pointer_size_matching.rs","byte_start":977,"byte_end":983,"line_start":32,"line_end":32,"column_start":11,"column_end":17,"is_primary":true,"text":[{"text":"    match 0usize { //~ ERROR non-exhaustive patterns","highlight_start":11,"highlight_end":17}],"label":"patterns `0usize` and `21usize..=18446744073709551615usize` not covered","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0004]: non-exhaustive patterns: `0usize` and `21usize..=18446744073709551615usize` not covered\n  --> /checkout/src/test/ui/precise_pointer_size_matching.rs:32:11\n   |\nLL |     match 0usize { //~ ERROR non-exhaustive patterns\n   |           ^^^^^^ patterns `0usize` and `21usize..=18446744073709551615usize` not covered\n\n"}
[00:46:39] {"message":"aborting due to 2 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 2 previous errors\n\n"}
[00:46:39] {"message":"For more information about this error, try `rustc --explain E0004`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0004`.\n"}
[00:46:39] ------------------------------------------
[00:46:39] 
[00:46:39] thread '[ui] ui/precise_pointer_size_matching.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3284:9
[00:46:39] 
---
[00:46:39] 
[00:46:39] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:503:22
[00:46:39] 
[00:46:39] 
[00:46:39] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:46:39] 
[00:46:39] 
[00:46:39] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:46:39] Build completed unsuccessfully in 0:03:43
[00:46:39] Build completed unsuccessfully in 0:03:43
[00:46:39] Makefile:58: recipe for target 'check' failed
[00:46:39] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0cb848aa
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu Dec  6 15:24:05 UTC 2018
---
travis_time:end:028b5074:start=1544109846619441444,finish=1544109846623543734,duration=4102290
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1416a224
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

varkor · 2018-12-06T15:28:04Z

@bors r=nikomatsakis rollup

I didn't spot what was going on before I force pushed, so now the change in this PR looks funny, but the original change got merged as part of the rollup #56557, without the fixes to the tests on 16-bit pointer size platforms. It's probably simplest to just merge the 16-bit fix as this PR now, but close the related issues.

bors · 2018-12-06T15:28:10Z

📌 Commit 944bb2ce8c41fa16839eb2834d99eaa079fd237a has been approved by nikomatsakis

rust-highfive · 2018-12-06T17:08:19Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:036bc6a0:start=1544115320588734196,finish=1544115322713412186,duration=2124677990
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
tidy check
[00:03:45] * 568 error codes
[00:03:45] * highest error code: E0721
[00:03:46] * 242 features
[00:03:46] invalid source: "git+https://github.com/rust-lang-nursery/rust-clippy?rev=f5d868c9edfc6c2a9310d564a2f738bec67dfd6b#f5d868c9edfc6c2a9310d564a2f738bec67dfd6b"
[00:03:46] invalid source: "git+https://github.com/rust-lang-nursery/rust-clippy?rev=f5d868c9edfc6c2a9310d564a2f738bec67dfd6b#f5d868c9edfc6c2a9310d564a2f738bec67dfd6b"
[00:03:46] some tidy checks failed
[00:03:46] 
[00:03:46] 
[00:03:46] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:46] 
[00:03:46] 
[00:03:46] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:46] Build completed unsuccessfully in 0:00:57
[00:03:46] Build completed unsuccessfully in 0:00:57
[00:03:46] Makefile:79: recipe for target 'tidy' failed
[00:03:46] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0456b30a
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu Dec  6 16:59:20 UTC 2018
---
travis_time:end:0f1e1310:start=1544115561114356868,finish=1544115561120312768,duration=5955900
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:11c91c9c
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:003890d0
travis_time:start:003890d0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:05d53320
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-12-06T17:17:12Z

@varkor Please rebase on the latest master. Or perhaps just close this and open a new PR as the stabilization itself is contained in #56557 already.

varkor · 2018-12-06T17:50:31Z

I've submitted #56567 as a follow up issue and I'll close this PR.

@varkor

…arkor Fix stabilization version numbers (exhaustive_integer_patterns + macro_literal_matcher) + `exhaustive_integer_patterns` slipped 1.32; merged in 1.33 -- rust-lang#56362 + `macro_literal_matcher` isn't stable on current stable (1.31) but is on beta (1.32). r? @varkor

@varkor

…arkor Fix stabilization version numbers (exhaustive_integer_patterns + macro_literal_matcher) + `exhaustive_integer_patterns` slipped 1.32; merged in 1.33 -- rust-lang#56362 + `macro_literal_matcher` isn't stable on current stable (1.31) but is on beta (1.32). r? @varkor

Pkgsrc changes: * Bump required rust version to build to 1.32.0. * Adapt patches to changed file locations. * Since we now patch some more vendor/ modules, doctor the corresponding .cargo-checksum.json files accordingly Upstream changes: Version 1.33.0 (2019-02-28) ========================== Language -------- - [You can now use the `cfg(target_vendor)` attribute.][57465] E.g. `#[cfg(target_vendor="apple")] fn main() { println!("Hello Apple!"); }` - [Integer patterns such as in a match expression can now be exhaustive.][56362] E.g. You can have match statement on a `u8` that covers `0..=255` and you would no longer be required to have a `_ => unreachable!()` case. - [You can now have multiple patterns in `if let` and `while let` expressions.][57532] You can do this with the same syntax as a `match` expression. E.g. ```rust enum Creature { Crab(String), Lobster(String), Person(String), } fn main() { let state = Creature::Crab("Ferris"); if let Creature::Crab(name) | Creature::Person(name) = state { println!("This creature's name is: {}", name); } } ``` - [You can now have irrefutable `if let` and `while let` patterns.][57535] Using this feature will by default produce a warning as this behaviour can be unintuitive. E.g. `if let _ = 5 {}` - [You can now use `let` bindings, assignments, expression statements, and irrefutable pattern destructuring in const functions.][57175] - [You can now call unsafe const functions.][57067] E.g. ```rust const unsafe fn foo() -> i32 { 5 } const fn bar() -> i32 { unsafe { foo() } } ``` - [You can now specify multiple attributes in a `cfg_attr` attribute.][57332] E.g. `#[cfg_attr(all(), must_use, optimize)]` - [You can now specify a specific alignment with the `#[repr(packed)]` attribute.][57049] E.g. `#[repr(packed(2))] struct Foo(i16, i32);` is a struct with an alignment of 2 bytes and a size of 6 bytes. - [You can now import an item from a module as an `_`.][56303] This allows you to import a trait's impls, and not have the name in the namespace. E.g. ```rust use std::io::Read as _; // Allowed as there is only one `Read` in the module. pub trait Read {} ``` - [You may now use `Rc`, `Arc`, and `Pin` as method receivers][56805]. Compiler -------- - [You can now set a linker flavor for `rustc` with the `-Clinker-flavor` command line argument.][56351] - [The mininum required LLVM version has been bumped to 6.0.][56642] - [Added support for the PowerPC64 architecture on FreeBSD.][57615] - [The `x86_64-fortanix-unknown-sgx` target support has been upgraded to tier 2 support.][57130] Visit the [platform support][platform-support] page for information on Rust's platform support. - [Added support for the `thumbv7neon-linux-androideabi` and `thumbv7neon-unknown-linux-gnueabihf` targets.][56947] - [Added support for the `x86_64-unknown-uefi` target.][56769] Libraries --------- - [The methods `overflowing_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57566] - [The methods `rotate_left`, `rotate_right`, and `wrapping_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57105] - [The methods `is_positive` and `is_negative` are now `const` functions for all signed numeric types.][57105] - [The `get` method for all `NonZero` types is now `const`.][57167] - [The methods `count_ones`, `count_zeros`, `leading_zeros`, `trailing_zeros`, `swap_bytes`, `from_be`, `from_le`, `to_be`, `to_le` are now `const` for all numeric types.][57234] - [`Ipv4Addr::new` is now a `const` function][57234] Stabilized APIs --------------- - [`unix::FileExt::read_exact_at`] - [`unix::FileExt::write_all_at`] - [`Option::transpose`] - [`Result::transpose`] - [`convert::identity`] - [`pin::Pin`] - [`marker::Unpin`] - [`marker::PhantomPinned`] - [`Vec::resize_with`] - [`VecDeque::resize_with`] - [`Duration::as_millis`] - [`Duration::as_micros`] - [`Duration::as_nanos`] Cargo ----- - [Cargo should now rebuild a crate if a file was modified during the initial build.][cargo/6484] Compatibility Notes ------------------- - The methods `str::{trim_left, trim_right, trim_left_matches, trim_right_matches}` are now deprecated in the standard library, and their usage will now produce a warning. Please use the `str::{trim_start, trim_end, trim_start_matches, trim_end_matches}` methods instead. - The `Error::cause` method has been deprecated in favor of `Error::source` which supports downcasting. [55982]: rust-lang/rust#55982 [56303]: rust-lang/rust#56303 [56351]: rust-lang/rust#56351 [56362]: rust-lang/rust#56362 [56642]: rust-lang/rust#56642 [56769]: rust-lang/rust#56769 [56805]: rust-lang/rust#56805 [56947]: rust-lang/rust#56947 [57049]: rust-lang/rust#57049 [57067]: rust-lang/rust#57067 [57105]: rust-lang/rust#57105 [57130]: rust-lang/rust#57130 [57167]: rust-lang/rust#57167 [57175]: rust-lang/rust#57175 [57234]: rust-lang/rust#57234 [57332]: rust-lang/rust#57332 [57465]: rust-lang/rust#57465 [57532]: rust-lang/rust#57532 [57535]: rust-lang/rust#57535 [57566]: rust-lang/rust#57566 [57615]: rust-lang/rust#57615 [cargo/6484]: rust-lang/cargo#6484 [`unix::FileExt::read_exact_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.read_exact_at [`unix::FileExt::write_all_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.write_all_at [`Option::transpose`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.transpose [`Result::transpose`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.transpose [`convert::identity`]: https://doc.rust-lang.org/std/convert/fn.identity.html [`pin::Pin`]: https://doc.rust-lang.org/std/pin/struct.Pin.html [`marker::Unpin`]: https://doc.rust-lang.org/stable/std/marker/trait.Unpin.html [`marker::PhantomPinned`]: https://doc.rust-lang.org/nightly/std/marker/struct.PhantomPinned.html [`Vec::resize_with`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.resize_with [`VecDeque::resize_with`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.resize_with [`Duration::as_millis`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_millis [`Duration::as_micros`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_micros [`Duration::as_nanos`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_nanos [platform-support]: https://forge.rust-lang.org/platform-support.html

rust-highfive assigned estebank Nov 30, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 30, 2018

varkor mentioned this pull request Nov 30, 2018

Tracking issue for RFC 2591: precise pattern matching on pointer size types #56354

Closed

2 tasks

This comment has been minimized.

Sign in to view

Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 30, 2018

varkor force-pushed the stabilise-exhaustive-integer-patterns branch from dd0f6c7 to e018268 Compare November 30, 2018 10:41

This comment has been minimized.

Sign in to view

Centril reviewed Nov 30, 2018

View reviewed changes

This was referenced Nov 30, 2018

Tracking issue for illegal_floating_point_literal_pattern compatibility lint #41620

Closed

E0005; should all constructors be listed? #56379

Closed

Centril mentioned this pull request Nov 30, 2018

Stabilization docs for RFC 2591 - exhaustive_integer_patterns rust-lang/reference#472

Closed

estebank reviewed Nov 30, 2018

View reviewed changes

src/test/ui/refutable-pattern-errors.stderr Show resolved Hide resolved

varkor force-pushed the stabilise-exhaustive-integer-patterns branch from 8af6373 to 4406391 Compare November 30, 2018 21:15

Centril approved these changes Nov 30, 2018

View reviewed changes

Centril mentioned this pull request Nov 30, 2018

Stabilise exhaustive integer pattern matching rust-lang/rfcs#2591

Merged

varkor mentioned this pull request Nov 30, 2018

Display {integer}::MIN/MAX in integer range suggestions rather than the expanded value #56393

Closed

eddyb reviewed Dec 2, 2018

View reviewed changes

rust-highfive assigned nikomatsakis and unassigned estebank Dec 2, 2018

nikomatsakis reviewed Dec 4, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2018

varkor force-pushed the stabilise-exhaustive-integer-patterns branch from ed64b19 to 5be3f0e Compare December 6, 2018 14:34

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 6, 2018

varkor force-pushed the stabilise-exhaustive-integer-patterns branch from 5be3f0e to 944bb2c Compare December 6, 2018 15:24

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 6, 2018

This comment has been minimized.

Sign in to view

Add 16-bit pointer size test for precise_pointer_size_matching

49e4f26

varkor force-pushed the stabilise-exhaustive-integer-patterns branch from 944bb2c to 49e4f26 Compare December 6, 2018 16:20

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 6, 2018

varkor closed this Dec 6, 2018

Centril mentioned this pull request Dec 21, 2018

Fix stabilization version numbers (exhaustive_integer_patterns + macro_literal_matcher) #57052

Merged

Centril mentioned this pull request Feb 11, 2019

Updated RELEASES.md for 1.33.0 #58227

Merged

Centril added this to the 1.33 milestone Apr 26, 2019

Uh oh!

Conversation

varkor commented Nov 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Nov 30, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

varkor commented Nov 30, 2018

Uh oh!

Centril commented Nov 30, 2018

Uh oh!

Uh oh!

Centril left a comment

Choose a reason for hiding this comment

Uh oh!

Centril commented Dec 1, 2018

Uh oh!

eddyb Dec 2, 2018

Choose a reason for hiding this comment

Uh oh!

nikomatsakis Dec 4, 2018

Choose a reason for hiding this comment

Uh oh!

varkor Dec 4, 2018

Choose a reason for hiding this comment

Uh oh!

eddyb commented Dec 2, 2018

Uh oh!

estebank commented Dec 3, 2018

Uh oh!

nikomatsakis left a comment

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented Dec 4, 2018

Uh oh!

bors commented Dec 4, 2018

Uh oh!

varkor commented Dec 6, 2018

Uh oh!

bors commented Dec 6, 2018

Uh oh!

bors commented Dec 6, 2018

Uh oh!

rust-highfive commented Dec 6, 2018

Uh oh!

varkor commented Dec 6, 2018

Uh oh!

bors commented Dec 6, 2018

Uh oh!

This comment has been minimized.

rust-highfive commented Dec 6, 2018

Uh oh!

kennytm commented Dec 6, 2018

Uh oh!

varkor commented Dec 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Comments

varkor commented Nov 30, 2018 •

edited

Loading