rustdoc: Don't modify library path for doctests by ollie27 · Pull Request #56514 · rust-lang/rust

ollie27 · 2018-12-04T18:46:10Z

It shouldn't be needed anymore because doctests are no longer compiled with prefer-dynamic (since #54939).

r? @QuietMisdreavus

QuietMisdreavus · 2018-12-04T19:01:24Z

This feels like something that could use a crater run...

QuietMisdreavus · 2018-12-04T19:34:42Z

Just to sate my paranoia, i'm going to try to run this through crater. First step...

@bors try

bors · 2018-12-04T19:34:54Z

⌛ Trying commit 7dd34d505bcccad927fa1f62414ee0294d1e4c0b with merge 6eb0fd3ac58f9b16bddb9924a17c3b6c156aa468...

bors · 2018-12-04T21:59:14Z

☀️ Test successful - status-travis
State: approved= try=True

QuietMisdreavus · 2018-12-04T22:15:26Z

@craterbot run start=master#906deae0790bd18681b937fe9a141a3c26cf1855 end=try#6eb0fd3ac58f9b16bddb9924a17c3b6c156aa468 mode=build-and-test

craterbot · 2018-12-04T22:15:28Z

👌 Experiment pr-56514 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2018-12-04T23:37:40Z

🚧 Experiment pr-56514 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2018-12-08T01:32:02Z

🎉 Experiment pr-56514 is completed!
📊 17 regressed and 15 fixed (50140 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Mark-Simulacrum · 2018-12-08T01:48:14Z

These are the suspicious looking logs, I believe the rest are spurious:

https://crater-reports.s3.amazonaws.com/pr-56514/try%236eb0fd3ac58f9b16bddb9924a17c3b6c156aa468/reg/liquid-0.17.1/log.txt
https://crater-reports.s3.amazonaws.com/pr-56514/try%236eb0fd3ac58f9b16bddb9924a17c3b6c156aa468/reg/read-byte-slice-0.1.2/log.txt
https://crater-reports.s3.amazonaws.com/pr-56514/try%236eb0fd3ac58f9b16bddb9924a17c3b6c156aa468/reg/sparkpost-0.5.2/log.txt
https://crater-reports.s3.amazonaws.com/pr-56514/try%236eb0fd3ac58f9b16bddb9924a17c3b6c156aa468/reg/strip-ansi-escapes-0.1.0/log.txt
https://crater-reports.s3.amazonaws.com/pr-56514/try%236eb0fd3ac58f9b16bddb9924a17c3b6c156aa468/reg/warp-0.1.9/log.txt
https://crater-reports.s3.amazonaws.com/pr-56514/try%236eb0fd3ac58f9b16bddb9924a17c3b6c156aa468/reg/xsv-0.13.0/log.txt

QuietMisdreavus · 2018-12-08T03:44:52Z

All of the legit failures look like docmatic-style tests where people run doctests from their README by calling rustdoc directly. I guess the directory they pass to rustdoc (-L target/debug/deps in most examples) has both the cfg(test) and cfg(not(test)) versions of the rlib in it, which confuses the crate loader.

However, the more i look at docmatic and skeptic reverse-deps, the more i see them everywhere on the report. I wonder if there's something else that's causing the failures, and this specific change isn't actually what's at fault.

Regardless, GitHub is now reporting a merge conflict.

XAMPPRocky · 2019-01-11T13:22:56Z

Triage; @ollie27 Hello, have you been able to get back to this PR?

bors · 2019-01-18T19:12:48Z

☔ The latest upstream changes (presumably #56189) made this pull request unmergeable. Please resolve the merge conflicts.

It shouldn't be needed anymore because doctests are no longer compiled with `prefer-dynamic`.

ollie27 · 2019-01-25T12:53:48Z

It doesn't look like any of those crater failures are because of this PR. Technically this PR does break running rustdoc -Cprefer-dynamic --test foo.rs but I don't know why anyone would do that.

QuietMisdreavus · 2019-02-18T19:54:23Z

Rustdoc taking arbitrary -C flags is fairly new (it was only added last year), so i don't think there's much risk of anyone doing that.

I'm going to go ahead and merge this PR - it's been sitting around long enough, and the Crater run showed that it doesn't affect anyone. Sorry for letting it sit forever!

@bors r+

bors · 2019-02-18T19:54:24Z

📌 Commit ad09d7f has been approved by QuietMisdreavus

bors · 2019-02-18T19:54:25Z

🌲 The tree is currently closed for pull requests below priority 160, this pull request will be tested once the tree is reopened

bors · 2019-02-19T07:27:46Z

⌛ Testing commit ad09d7f with merge fcccf06...

@QuietMisdreavus

rustdoc: Don't modify library path for doctests It shouldn't be needed anymore because doctests are no longer compiled with `prefer-dynamic` (since #54939). r? @QuietMisdreavus

bors · 2019-02-19T10:06:49Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: QuietMisdreavus
Pushing fcccf06 to master...

rust-highfive assigned QuietMisdreavus Dec 4, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2018

ollie27 mentioned this pull request Dec 4, 2018

rustdoc: Add option to persist doc test executables #56189

Merged

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2018

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 8, 2018

QuietMisdreavus added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2018

ollie27 force-pushed the rustdoc_test_libdir branch from 7dd34d5 to 0f0c2a3 Compare January 17, 2019 10:32

rustdoc: Don't modify library path for doctests

ad09d7f

It shouldn't be needed anymore because doctests are no longer compiled with `prefer-dynamic`.

ollie27 force-pushed the rustdoc_test_libdir branch from 0f0c2a3 to ad09d7f Compare January 20, 2019 10:15

Dylan-DPC-zz added S-waiting-on-team and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 4, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team labels Feb 18, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 19, 2019

bors merged commit ad09d7f into rust-lang:master Feb 19, 2019

This was referenced Feb 19, 2019

Make the rustc driver and interface demand driven #56732

Merged

Introduce rustc_interface and move some methods there #58250

Merged

ollie27 deleted the rustdoc_test_libdir branch February 24, 2019 18:26

Mark-Simulacrum mentioned this pull request Mar 2, 2019

Huge performance regression in rustdoc between 1/28 and 2/25 nightlies #58849

Closed

Uh oh!

Comments

Conversation

ollie27 commented Dec 4, 2018

Uh oh!

QuietMisdreavus commented Dec 4, 2018

Uh oh!

QuietMisdreavus commented Dec 4, 2018

Uh oh!

bors commented Dec 4, 2018

Uh oh!

bors commented Dec 4, 2018

Uh oh!

QuietMisdreavus commented Dec 4, 2018

Uh oh!

craterbot commented Dec 4, 2018

Uh oh!

craterbot commented Dec 4, 2018

Uh oh!

craterbot commented Dec 8, 2018

Uh oh!

Mark-Simulacrum commented Dec 8, 2018

Uh oh!

QuietMisdreavus commented Dec 8, 2018

Uh oh!

XAMPPRocky commented Jan 11, 2019

Uh oh!

bors commented Jan 18, 2019

Uh oh!

ollie27 commented Jan 25, 2019

Uh oh!

QuietMisdreavus commented Feb 18, 2019

Uh oh!

bors commented Feb 18, 2019

Uh oh!

bors commented Feb 18, 2019

Uh oh!

bors commented Feb 19, 2019

Uh oh!

bors commented Feb 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants