Stabilize min_const_unsafe_fn in 1.33 by Centril · Pull Request #57067 · rust-lang/rust

Centril · 2018-12-22T18:08:02Z

Fixes #55607

r? @oli-obk

Centril

Not entirely sure about the stage0 stuff...

src/libstd/lib.rs

src/test/rustdoc/const-display.rs

src/test/ui/consts/const-size_of-cycle.stderr

oli-obk · 2018-12-23T00:05:25Z

We need to update the docs, too. At least that's an open point in the issue, so this PR doesn't fix the issue as described in the PR message

Centril · 2018-12-23T09:38:02Z

@oli-obk Rebased. I've also filed documentation issue (rust-lang/reference#482) for the reference; we can track needed documentation changes from there. :)

oli-obk · 2018-12-23T12:22:36Z

@bors r+

bors · 2018-12-23T12:22:37Z

📌 Commit 7ae6fb2 has been approved by oli-obk

@oli-obk

…fn, r=oli-obk Stabilize min_const_unsafe_fn in 1.33 Fixes rust-lang#55607 r? @oli-obk

@oli-obk

…fn, r=oli-obk Stabilize min_const_unsafe_fn in 1.33 Fixes rust-lang#55607 r? @oli-obk

@ghost

Rollup of 14 pull requests Successful merges: - #56188 (enum type instead of variant suggestion unification ) - #56342 (Improve docs for collecting into `Option`s) - #56916 (Fix mutable references in `static mut`) - #56917 (Simplify MIR generation for logical operations) - #56939 (Pin stabilization) - #56953 (Mark tuple structs as live if their constructors are used) - #56964 (Remove `TokenStream::JointTree`.) - #56966 (Correct strings for raw pointer deref and array access suggestions) - #57020 (Point to cause of `fn` expected return type) - #57032 (fix deprecation warnings in liballoc benches) - #57053 (Fix alignment for array indexing) - #57062 (Fix a comment) - #57067 (Stabilize min_const_unsafe_fn in 1.33) - #57078 (Ignore two tests on s390x) Failed merges: r? @ghost

jethrogb · 2019-01-01T05:41:25Z

I'm slightly confused as to why this feature was stabilized after being in master for only 18 days. Surely it could've been insta-stable or there should've been an FCP?

Pkgsrc changes: * Bump required rust version to build to 1.32.0. * Adapt patches to changed file locations. * Since we now patch some more vendor/ modules, doctor the corresponding .cargo-checksum.json files accordingly Upstream changes: Version 1.33.0 (2019-02-28) ========================== Language -------- - [You can now use the `cfg(target_vendor)` attribute.][57465] E.g. `#[cfg(target_vendor="apple")] fn main() { println!("Hello Apple!"); }` - [Integer patterns such as in a match expression can now be exhaustive.][56362] E.g. You can have match statement on a `u8` that covers `0..=255` and you would no longer be required to have a `_ => unreachable!()` case. - [You can now have multiple patterns in `if let` and `while let` expressions.][57532] You can do this with the same syntax as a `match` expression. E.g. ```rust enum Creature { Crab(String), Lobster(String), Person(String), } fn main() { let state = Creature::Crab("Ferris"); if let Creature::Crab(name) | Creature::Person(name) = state { println!("This creature's name is: {}", name); } } ``` - [You can now have irrefutable `if let` and `while let` patterns.][57535] Using this feature will by default produce a warning as this behaviour can be unintuitive. E.g. `if let _ = 5 {}` - [You can now use `let` bindings, assignments, expression statements, and irrefutable pattern destructuring in const functions.][57175] - [You can now call unsafe const functions.][57067] E.g. ```rust const unsafe fn foo() -> i32 { 5 } const fn bar() -> i32 { unsafe { foo() } } ``` - [You can now specify multiple attributes in a `cfg_attr` attribute.][57332] E.g. `#[cfg_attr(all(), must_use, optimize)]` - [You can now specify a specific alignment with the `#[repr(packed)]` attribute.][57049] E.g. `#[repr(packed(2))] struct Foo(i16, i32);` is a struct with an alignment of 2 bytes and a size of 6 bytes. - [You can now import an item from a module as an `_`.][56303] This allows you to import a trait's impls, and not have the name in the namespace. E.g. ```rust use std::io::Read as _; // Allowed as there is only one `Read` in the module. pub trait Read {} ``` - [You may now use `Rc`, `Arc`, and `Pin` as method receivers][56805]. Compiler -------- - [You can now set a linker flavor for `rustc` with the `-Clinker-flavor` command line argument.][56351] - [The mininum required LLVM version has been bumped to 6.0.][56642] - [Added support for the PowerPC64 architecture on FreeBSD.][57615] - [The `x86_64-fortanix-unknown-sgx` target support has been upgraded to tier 2 support.][57130] Visit the [platform support][platform-support] page for information on Rust's platform support. - [Added support for the `thumbv7neon-linux-androideabi` and `thumbv7neon-unknown-linux-gnueabihf` targets.][56947] - [Added support for the `x86_64-unknown-uefi` target.][56769] Libraries --------- - [The methods `overflowing_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57566] - [The methods `rotate_left`, `rotate_right`, and `wrapping_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57105] - [The methods `is_positive` and `is_negative` are now `const` functions for all signed numeric types.][57105] - [The `get` method for all `NonZero` types is now `const`.][57167] - [The methods `count_ones`, `count_zeros`, `leading_zeros`, `trailing_zeros`, `swap_bytes`, `from_be`, `from_le`, `to_be`, `to_le` are now `const` for all numeric types.][57234] - [`Ipv4Addr::new` is now a `const` function][57234] Stabilized APIs --------------- - [`unix::FileExt::read_exact_at`] - [`unix::FileExt::write_all_at`] - [`Option::transpose`] - [`Result::transpose`] - [`convert::identity`] - [`pin::Pin`] - [`marker::Unpin`] - [`marker::PhantomPinned`] - [`Vec::resize_with`] - [`VecDeque::resize_with`] - [`Duration::as_millis`] - [`Duration::as_micros`] - [`Duration::as_nanos`] Cargo ----- - [Cargo should now rebuild a crate if a file was modified during the initial build.][cargo/6484] Compatibility Notes ------------------- - The methods `str::{trim_left, trim_right, trim_left_matches, trim_right_matches}` are now deprecated in the standard library, and their usage will now produce a warning. Please use the `str::{trim_start, trim_end, trim_start_matches, trim_end_matches}` methods instead. - The `Error::cause` method has been deprecated in favor of `Error::source` which supports downcasting. [55982]: rust-lang/rust#55982 [56303]: rust-lang/rust#56303 [56351]: rust-lang/rust#56351 [56362]: rust-lang/rust#56362 [56642]: rust-lang/rust#56642 [56769]: rust-lang/rust#56769 [56805]: rust-lang/rust#56805 [56947]: rust-lang/rust#56947 [57049]: rust-lang/rust#57049 [57067]: rust-lang/rust#57067 [57105]: rust-lang/rust#57105 [57130]: rust-lang/rust#57130 [57167]: rust-lang/rust#57167 [57175]: rust-lang/rust#57175 [57234]: rust-lang/rust#57234 [57332]: rust-lang/rust#57332 [57465]: rust-lang/rust#57465 [57532]: rust-lang/rust#57532 [57535]: rust-lang/rust#57535 [57566]: rust-lang/rust#57566 [57615]: rust-lang/rust#57615 [cargo/6484]: rust-lang/cargo#6484 [`unix::FileExt::read_exact_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.read_exact_at [`unix::FileExt::write_all_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.write_all_at [`Option::transpose`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.transpose [`Result::transpose`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.transpose [`convert::identity`]: https://doc.rust-lang.org/std/convert/fn.identity.html [`pin::Pin`]: https://doc.rust-lang.org/std/pin/struct.Pin.html [`marker::Unpin`]: https://doc.rust-lang.org/stable/std/marker/trait.Unpin.html [`marker::PhantomPinned`]: https://doc.rust-lang.org/nightly/std/marker/struct.PhantomPinned.html [`Vec::resize_with`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.resize_with [`VecDeque::resize_with`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.resize_with [`Duration::as_millis`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_millis [`Duration::as_micros`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_micros [`Duration::as_nanos`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_nanos [platform-support]: https://forge.rust-lang.org/platform-support.html

rust-highfive assigned oli-obk Dec 22, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 22, 2018

Centril commented Dec 22, 2018

View reviewed changes

src/libstd/lib.rs Outdated Show resolved Hide resolved

src/test/rustdoc/const-display.rs Outdated Show resolved Hide resolved

Centril mentioned this pull request Dec 22, 2018

Tracking issue for unsafe operations in const fn #55607

Closed

4 tasks

oli-obk reviewed Dec 22, 2018

View reviewed changes

src/test/ui/consts/const-size_of-cycle.stderr Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Dec 22, 2018

This comment has been minimized.

Sign in to view

Centril mentioned this pull request Dec 23, 2018

Document min_const_unsafe_fn rust-lang/reference#482

Closed

Centril added 3 commits December 23, 2018 10:29

stabilize min_const_unsafe_fn in 1.33.

b42a3ac

stabilize min_const_unsafe_fn --bless tests.

bd1d5bc

stabilize min_const_unsafe_fn -- revert const-size_of-cycle changes

7ae6fb2

Centril force-pushed the stabilize-min_const_unsafe_fn branch from 5f324a0 to 7ae6fb2 Compare December 23, 2018 09:30

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2018

Centril added a commit to Centril/rust that referenced this pull request Dec 23, 2018

Rollup merge of rust-lang#57067 - Centril:stabilize-min_const_unsafe_…

24a5335

…fn, r=oli-obk Stabilize min_const_unsafe_fn in 1.33 Fixes rust-lang#55607 r? @oli-obk

Centril mentioned this pull request Dec 23, 2018

Rollup of 10 pull requests #57083

Closed

Centril added a commit to Centril/rust that referenced this pull request Dec 23, 2018

Rollup merge of rust-lang#57067 - Centril:stabilize-min_const_unsafe_…

975a7f0

…fn, r=oli-obk Stabilize min_const_unsafe_fn in 1.33 Fixes rust-lang#55607 r? @oli-obk

Centril mentioned this pull request Dec 23, 2018

Rollup of 14 pull requests #57087

Merged

bors merged commit 7ae6fb2 into rust-lang:master Dec 24, 2018

Centril deleted the stabilize-min_const_unsafe_fn branch December 24, 2018 10:05

Centril added the T-lang Relevant to the language team label Jan 10, 2019

Centril added this to the 1.33 milestone Apr 26, 2019

MSxDOS mentioned this pull request Jun 22, 2019

Tracking Issue for using std::mem::transmute() in const fn (const_fn_transmute) #53605

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Stabilize min_const_unsafe_fn in 1.33#57067

Stabilize min_const_unsafe_fn in 1.33#57067
bors merged 3 commits intorust-lang:masterfrom
Centril:stabilize-min_const_unsafe_fn

Centril commented Dec 22, 2018

Uh oh!

Centril left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

oli-obk commented Dec 23, 2018

Uh oh!

This comment has been minimized.

Centril commented Dec 23, 2018

Uh oh!

oli-obk commented Dec 23, 2018

Uh oh!

bors commented Dec 23, 2018

Uh oh!

jethrogb commented Jan 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Uh oh!

Conversation

Centril commented Dec 22, 2018

Uh oh!

Centril left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

oli-obk commented Dec 23, 2018

Uh oh!

This comment has been minimized.

Centril commented Dec 23, 2018

Uh oh!

oli-obk commented Dec 23, 2018

Uh oh!

bors commented Dec 23, 2018

Uh oh!

jethrogb commented Jan 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments