Merged
Conversation
…illaumeGomez do not print panic message on doctest failures This PR cleans up rustdoc test output by silently unwinding on failure instead of using `panic!`. It also improves the clarity and consistency of the output on test failure, and adds test cases for failure modes that were previously untested.
…=GuillaumeGomez strip synstructure consts from compiler docs Fixes rust-lang#60150. Unfortunately this PR depends on the use of the deprecated `--passes` flag in bootstrap to keep the `--strip-hidden` pass while still documenting private items. I've opened rust-lang#60884 to track stabilization of a new flag that encapsulates this behavior. r? @QuietMisdreavus
Account for short-hand init structs when suggesting conversion Fix rust-lang#52820.
…i-obk is_union returns ty to avoid computing it twice r? @oli-obk
… r=GuillaumeGomez Print const generics properly in rustdoc Now that rust-lang#59276 is merged, we can print consts properly in rustdoc. Fixes rust-lang#60737. Fixes rust-lang#61257. r? @GuillaumeGomez
split libcore::mem into multiple files r? @Centril
Simplify Set1::insert r? @varkor
Contributor
Author
|
@bors r+ p=7 |
Collaborator
|
📌 Commit b742d7e has been approved by |
bors
added
the
S-waiting-on-bors
Contributor
|
@bors rollup=never |
Member
|
@bors retry |
Collaborator
bors
added a commit
that referenced
this pull request
May 29, 2019
Rollup of 7 pull requests Successful merges: - #60549 (do not print panic message on doctest failures) - #60885 (strip synstructure consts from compiler docs) - #61217 (Account for short-hand init structs when suggesting conversion) - #61261 (is_union returns ty to avoid computing it twice) - #61293 (Print const generics properly in rustdoc) - #61310 (split libcore::mem into multiple files) - #61313 (Simplify Set1::insert) Failed merges: r? @ghost
Collaborator
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost