Panic if NodeIds are used for incremental compilation

[Zoxc]

r? @michaelwoerister

[Zoxc]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion

[bors]

⌛ Trying commit e517ee9 with merge 4e727aa...

[bors]

☀️ Try build successful - checks-azure
Build commit: 4e727aa (4e727aa494e3766fe1f66d9a5c87078a58eabcf2)

[rust-timer]

Queued 4e727aa with parent 6dff769, future comparison URL.

[Zoxc]

This makes the query system treat node ids as pure integers (which is what they are) instead of HIR ids.

cc @rust-lang/compiler Does anyone know of any scenarios this would break?

[Zoxc]

In order to do this, we'd have to track node_to_hir_id as that would reveal the HirId now. There's just 1 call of it left in the compiler proper though (some more in save-analysis).

[eddyb]

Do we deal with NodeIds anymore though? Can we remove these impls?

[Zoxc]

They exist in macro defs and attributes (in token trees). I'm not sure if they are actually used for anything though.

[eddyb]

cc @petrochenkov (sounds like the problem is interpolated Nonterminals?)

[petrochenkov]

@eddyb, do you remember these PRs - #56492 ("syntax: use MetaPath (a simpler version of Path) for Attribute and MetaItem"), #56480 (Use hir::Path instead of ast::Path in HIR Attribute's)?
The goal was to avoid AST types being embedded into HIR types due to attributes.

[petrochenkov]

Nonterminal tokens don't exist in HIR, they are converted into primitive tokens during AST -> HIR lowering, so NodeIds shouldn't exist in HIR either. HIR hashing can insert some kind of runtime panic for them.

[eddyb]

@eddyb, do you remember these PRs - #56492 ("syntax: use MetaPath (a simpler version of Path) for Attribute and MetaItem"), #56480 (Use hir::Path instead of ast::Path in HIR Attribute's)?

Oh right, it's... been a while. I plan to eventually go over unfinished work like that as soon as it's possible, but things keep coming up and most of my plans end up in the trash.
All I can do for the time being is apologize, I suppose.

HIR hashing can insert some kind of runtime panic for them.

I wanted to suggest panicking but I wasn't sure if we're expecting leftover NodeIds, thanks!

[Zoxc]

I made this panic instead.

r? @petrochenkov

[petrochenkov]

@bors r+
(If it passes through CI.)

[bors]

📌 Commit 8a37811 has been approved by petrochenkov

[bors]

⌛ Testing commit 8a37811 with merge 116dff9...

[bors]

☀️ Test successful - checks-azure
Approved by: petrochenkov
Pushing 116dff9 to master...