Conversation
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
4 tasks
Contributor
|
Just pointing out that the RFC contains a bit of a contradiction and this PR's tests don't appear to test that case: rust-lang/rfcs#2509 (comment) |
Contributor
Author
|
@Fishrock123 That appears to have been an oversight when updating the RFC. I've added a test for it. |
Member
|
Rerolling r? rust-lang/compiler |
Member
|
Looks like this is ready for review |
The tracking issue for this is rust-lang#87555.
c1cc810 to
eb56693
Compare
Member
|
Squashed commits, looks good to me, thanks! @bors r+ |
Collaborator
|
📌 Commit eb56693 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 9, 2021
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#87599 (Implement concat_bytes!) - rust-lang#89999 (Update std::env::temp_dir to use GetTempPath2 on Windows when available.) - rust-lang#90796 (Remove the reg_thumb register class for asm! on ARM) - rust-lang#91042 (Use Vec extend instead of repeated pushes on several places) - rust-lang#91634 (Do not attempt to suggest help for overly malformed struct/function call) - rust-lang#91685 (Install llvm tools to sysroot when assembling local toolchain) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the unstable
concat_bytes!macro, which has tracking issue #87555. It can be used like:If strings or characters are used where byte strings or byte characters are required, it suggests adding a
bprefix. If a number is used outside of an array it suggests arrayifying it. If a boolean is used it suggests replacing it with the numeric value of that number. Doubly nested arrays of bytes are disallowed.