Skip to content

Suggest implementing #[derive(PartialEq)] for types in vectors and arrays#95371

Closed
TaKO8Ki wants to merge 1 commit intorust-lang:masterfrom
TaKO8Ki:suggest-using-derive-partialeq-for-types-in-vector-and-array
Closed

Suggest implementing #[derive(PartialEq)] for types in vectors and arrays#95371
TaKO8Ki wants to merge 1 commit intorust-lang:masterfrom
TaKO8Ki:suggest-using-derive-partialeq-for-types-in-vector-and-array

Conversation

@TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Mar 27, 2022

closes #95285

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 27, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented Mar 27, 2022

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2022
compiler-errors
compiler-errors reviewed Mar 27, 2022
View reviewed changes
compiler/rustc_typeck/src/check/method/suggest.rs
}
}

if Some(trait_pred.trait_ref.def_id) == self.tcx.lang_items().eq_trait() {
Copy link
Contributor

@compiler-errors compiler-errors Mar 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave a comment for what this function does? Also a comment explaining the special casing just for Eq. Alternatively, we could think of some way to generalize this?

Copy link
Member Author

@TaKO8Ki TaKO8Ki Mar 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. In case of PartialOrd, rustc properly explains why xs can't be compared with [X, X, X].

fn main() {
    struct X;
    let xs = [X, X, X];
    let eq = xs > [X, X, X];
}

https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=7115dbcd188f44a242ba8640347bbfe3

Copy link
Contributor

@cjgillot cjgillot Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to implement the PartialEq suggestion by re-using the code for PartialOrd?

Copy link
Member Author

@TaKO8Ki TaKO8Ki Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'm going to do it.

@cjgillot cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2022
@bors
Copy link
Collaborator

bors commented Apr 27, 2022

☔ The latest upstream changes (presumably #96459) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC
Copy link
Member

Dylan-DPC commented Aug 2, 2022

@TaKO8Ki any updates on this?

@JohnCSimon
Copy link
Member

JohnCSimon commented Jan 29, 2023

@TaKO8Ki
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Jan 29, 2023
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjgillot cjgillot cjgillot left review comments

+1 more reviewer

@compiler-errors compiler-errors compiler-errors left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cjgillot cjgillot

Labels

S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unhelpful error message when comparing an array of types that are not comparable

8 participants

@TaKO8Ki @rust-highfive @bors @Dylan-DPC @JohnCSimon @cjgillot @compiler-errors @rustbot