Split compile tests from run tests
#846
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
compile-only
branch
from
09a6722 to
2f3ef5c
Compare
GuillaumeGomez
force-pushed
the
compile-only
branch
from
2f3ef5c to
9458f58
Compare
GuillaumeGomez
force-pushed
the
compile-only
branch
from
9458f58 to
3c61fd8
Compare
Member
Author
|
Ah that one is interesting. It means that when I did #841, it didn't check for m68k somehow. There doesn't seem to be a direct translation for |
Contributor
Are you sure it's not a rustc error? In any case, I believe it's OK to ignore it for m68k. |
GuillaumeGomez
force-pushed
the
compile-only
branch
3 times, most recently
from
a801362 to
0fa1498
Compare
GuillaumeGomez
force-pushed
the
compile-only
branch
from
0fa1498 to
0893417
Compare
Member
Author
|
CI finally passed! \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #845.
This PR introduces a second step to check that some tests only need to compile.
First commit is from #845.