docs: do not inline x86 instrinsics into x86-64#1656
Open
notriddle wants to merge 2 commits intorust-lang:mainfrom
Open
docs: do not inline x86 instrinsics into x86-64#1656notriddle wants to merge 2 commits intorust-lang:mainfrom
notriddle wants to merge 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks. |
This reduces the size of the `core/arch` HTML from about 187M to 132M.
988350f to
926b559
Compare
Member
|
While this does reduce the size, it actually makes the documentation incorrect: |
Author
|
I can remove the incorrect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the size of the
core/archHTML from about 187M to 132M.