Intrinsic-test: Updated the Constraint enum to support discrete values#1892
Conversation
|
r? @folkertdev rustbot has assigned @folkertdev. Use |
|
@folkertdev I remember our discussion on whether there might be a better name than "Constraint". Essentially, this feature is present for arguments that have a restricted set of legal values. Would a word like "Restriction" or so be more appropriate? |
|
I was thinking something more like Weirdly CI fails in |
In this context though, would it be appropriate? /// An argument for the intrinsic.
#[derive(Debug, PartialEq, Clone)]
pub struct Argument<T: IntrinsicTypeDefinition> {
/// The argument's index in the intrinsic function call.
pub pos: usize,
/// The argument name.
pub name: String,
/// The type of the argument.
pub ty: T,
/// Any constraints that are on this argument
pub constraint: Option<Constraint>,
}
Let me try making another commit, perhaps this might be a one-off occurrence with the CI |
|
#1893 fixes the loongarch issue |
Hmm, let's just leave it as |
51cf357 to
7dd81ca
Compare
Context
This PR is part of the changes that were originally made in the x86 extension PR #1814 for
intrinsic-test, and is intended to unblock efforts to support other architectures too.Further context: #1884 (comment)
cc: @folkertdev @Amanieu