Skip to content

wasm: use intrinsics::simd for dot product #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
folkertdev wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Draft

wasm: use intrinsics::simd for dot product #2015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions crates/core_arch/src/wasm32/simd128.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,6 @@ unsafe extern "unadjusted" {
fn llvm_i32x4_all_true(x: simd::i32x4) -> i32;
#[link_name = "llvm.wasm.bitmask.v4i32"]
fn llvm_bitmask_i32x4(a: simd::i32x4) -> i32;
#[link_name = "llvm.wasm.dot"]
fn llvm_i32x4_dot_i16x8_s(a: simd::i16x8, b: simd::i16x8) -> simd::i32x4;

#[link_name = "llvm.wasm.alltrue.v2i64"]
fn llvm_i64x2_all_true(x: simd::i64x2) -> i32;
Expand Down Expand Up @@ -3342,7 +3340,14 @@ pub fn u32x4_max(a: v128, b: v128) -> v128 {
#[doc(alias("i32x4.dot_i16x8_s"))]
#[stable(feature = "wasm_simd", since = "1.54.0")]
pub fn i32x4_dot_i16x8(a: v128, b: v128) -> v128 {
unsafe { llvm_i32x4_dot_i16x8_s(a.as_i16x8(), b.as_i16x8()).v128() }
unsafe {
let prod: simd::i32x8 = simd_mul(simd_cast(a.as_i16x8()), simd_cast(b.as_i16x8()));

let evens: simd::i32x4 = simd_shuffle!(prod, prod, [0, 2, 4, 6]);
let odds: simd::i32x4 = simd_shuffle!(prod, prod, [1, 3, 5, 7]);

simd_add(evens, odds).v128()
}
}

/// Lane-wise integer extended multiplication producing twice wider result than
Expand Down
Loading