virtio-queue: Add helpers for accessing queue information#132
Merged
sboeuf merged 1 commit intorust-vmm:mainfrom Jan 28, 2022
Merged
virtio-queue: Add helpers for accessing queue information#132sboeuf merged 1 commit intorust-vmm:mainfrom
sboeuf merged 1 commit intorust-vmm:mainfrom
Conversation
sboeuf
force-pushed
the
add_queue_helpers
branch
from
163b256 to
a32c2a3
Compare
lauralt
reviewed
Jan 25, 2022
sboeuf
force-pushed
the
add_queue_helpers
branch
2 times, most recently
from
6c2c4bc to
dd8ed18
Compare
Author
|
PR's ready for review. |
jiangliu
reviewed
Jan 28, 2022
Member
|
Thanks for improving the unit test logic:) |
sboeuf
force-pushed
the
add_queue_helpers
branch
2 times, most recently
from
8c197cd to
27b233e
Compare
lauralt
reviewed
Jan 28, 2022
jiangliu
previously approved these changes
Jan 28, 2022
sboeuf
force-pushed
the
add_queue_helpers
branch
from
27b233e to
fc417a1
Compare
Author
|
@lauralt PR updated! |
lauralt
previously approved these changes
Jan 28, 2022
Contributor
lauralt
left a comment
lauralt
left a comment
There was a problem hiding this comment.
Thanks for the improvements!
These helpers are meant to help crate's consumers getting and setting information about the queue. Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
sboeuf
force-pushed
the
add_queue_helpers
branch
from
fc417a1 to
fae1928
Compare
lauralt
approved these changes
Jan 28, 2022
rbradford
approved these changes
Jan 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These helpers are meant to help crate's consumers getting and setting
information about the queue.
Signed-off-by: Sebastien Boeuf sebastien.boeuf@intel.com