Skip to content

Move create PR shortcut into tooltip #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruudandriessen merged 1 commit into from
Mar 10, 2026
Merged

Move create PR shortcut into tooltip #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 26 additions & 12 deletions src/components/task-page-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { ExternalLink } from "lucide-react";
import { OpenEditorDropdown } from "@/components/open-editor-dropdown";
import { Button } from "@/components/ui/button";
import { Kbd } from "@/components/ui/kbd";
import { Tooltip, TooltipContent, TooltipTrigger } from "@/components/ui/tooltip";
import { hotkeys } from "@/lib/hotkeys";
import {
formatChecksProgress,
Expand Down Expand Up @@ -52,6 +53,30 @@ export function TaskPageHeader({
const canCreatePr = !!branchName && !pullRequest && !sending && !isRunning;
useHotkey(hotkeys.createPr.keys, () => onCreatePr(), { enabled: canCreatePr });

const createPrButton = branchName ? (
<Tooltip>
<TooltipTrigger asChild>
<span tabIndex={-1}>
<Button
type="button"
variant="outline"
size="xs"
disabled={sending || isRunning}
onClick={onCreatePr}
>
Create PR
</Button>
</span>
</TooltipTrigger>
<TooltipContent>
<span className="flex items-center gap-2">
{hotkeys.createPr.label}
<Kbd keys={hotkeys.createPr.keys} />
</span>
</TooltipContent>
</Tooltip>
) : null;

return (
<div className="shrink-0 border-b border-border bg-card px-4 py-3 md:px-6">
<div className="flex flex-col gap-2 md:flex-row md:items-center md:justify-between">
Expand Down Expand Up @@ -121,18 +146,7 @@ export function TaskPageHeader({
</div>
</div>
) : branchName ? (
<div className="space-y-1 text-right">
<Button
type="button"
variant="outline"
size="xs"
disabled={sending || isRunning}
onClick={onCreatePr}
>
Create a PR
<Kbd keys={hotkeys.createPr.keys} />
</Button>
</div>
<div className="space-y-1 text-right">{createPrButton}</div>
) : null}
</div>
</div>
Expand Down
Loading