Update diesel-async to 0.6, and remove an unnecessary Sync bound#2972
Merged
the10thWiz merged 1 commit intomasterfrom Dec 28, 2025
Merged
Update diesel-async to 0.6, and remove an unnecessary Sync bound#2972the10thWiz merged 1 commit intomasterfrom
the10thWiz merged 1 commit intomasterfrom
Conversation
|
I can successfully complete the tests now on my machine. I think this PR works |
|
By the way, in my testing against this PR, you could bump diesel-async as far as 0.6.1 and diesel to 2.2.12. diff --git a/contrib/db_pools/lib/Cargo.toml b/contrib/db_pools/lib/Cargo.toml
index a0a911bd..b88f52db 100644
--- a/contrib/db_pools/lib/Cargo.toml
+++ b/contrib/db_pools/lib/Cargo.toml
@@ -65,13 +65,13 @@ features = ["compat-3-0-0", "rustls-tls"]
optional = true
[dependencies.diesel-async]
-version = "0.6.0"
+version = "0.6.1"
default-features = false
features = ["async-connection-wrapper"]
optional = true
[dependencies.diesel]
-version = "2.1"
+version = "2.2.12"
default-features = false
optional = true(There is a diesel 2.3.x but diesel_async is not yet ready to support it.) With this patch both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Syncbound onPoolis, as far as I can tell, unneeded.diesel-async's mysql connection pool isn'tSyncanymore,which is why bound needed to be removed.
closes: #2969