Strap log: soften stale-RTC diag wording ("no clock correlation at decode") — #67 follow-up#71
Merged
Merged
Conversation
…ecode", not "never" (#67 follow-up) The identity-fallback diagnostic line (#69) asserted "(GET_CLOCK never correlated)", but sessionUsedIdentityRef is captured on the FIRST chunk. In the normal flow the correlation lands before chunk 1, and in the reset-RTC case it never lands — both fine. But on a slow link GET_CLOCK can reply late: chunk 1 decodes on the identity fallback, later chunks on the real ref, so "never" is false. First-chunk capture is still the right choice (it flags that the early rows landed misdated), only the absolute word overreached — reword to "(no clock correlation at decode)", true regardless of any later reply. Doc comment + test assertion updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #69 (re-review finding). No behaviour change; log wording only.
The identity-fallback line printed
(GET_CLOCK never correlated), butsessionUsedIdentityRefis captured on the first chunk of the session. Normally the clock correlation lands before chunk 1 (the offload is deferred ~1.5s for exactly that); in the reset-RTC case it never lands — both accurate. But on a slow link GET_CLOCK can reply late: chunk 1 decodes on the identity fallback, later chunks on the real ref — so "never" is false.First-chunk capture is still correct for this diagnostic (the early rows are the ones that landed misdated, which is what we want flagged); only the absolute word overreached. Reworded to
(no clock correlation at decode), which is true whether or not a late reply lands afterward. Doc comment and the exact-match test assertion updated to match.Files:
Strand/Collect/Backfiller.swift,StrandTests/BackfillerSessionTallyTests.swift.