Fix dup_length handling for short reads#190
Merged
s-andrews merged 1 commit intoMay 20, 2026
Merged
Conversation
Owner
|
Thanks for submitting this. That fix looks good to me, I'll merge it for the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145.
When
fastqc.dup_length/--dup_lengthis longer than a read, the overrepresented sequence module currently callssubstring(0, dupLength)and crashes withStringIndexOutOfBoundsException.This change caps the duplication truncation length at the actual sequence length, so short reads are kept whole instead of failing.
Also adds an integration regression test using the existing 16bp
minimal.fastqfixture withfastqc.dup_length=20.Validation:
fastqc.dup_length=20againsttest/data/minimal.fastqbefore the fix.DupLengthTest: 1 test found, 1 succeeded, 0 failed.git diff --check.