fix(api): remove duplicate router registrations#260
Open
HemantDhaker12 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #248
Summary of Changes
Removed duplicate router registrations for
actions.routerandcontext.routerinapi/main.py.This fixes duplicate runtime route entries that were confirmed through runtime inspection of
app.routes.Type of Change
How Was This Tested?
Runtime verification
Verified route registrations before and after the fix using:
Confirmed:
/api/v1/actionsroutes were removed/api/v1/contextroutes were removedApplication startup verification
Verified:
/docsTest environment:
📸 Screenshots / Recordings (if applicable)
N/A
Pre-Submission Checklist
upstream/main.envfiles, secrets, or model weightsNotes
Repository-wide
mypyandbanditpre-commit checks currently report existing unrelated issues outside the scope of this PR.Additional Notes for Reviewer
Swagger UI did not visibly expose the duplication, but runtime inspection of
app.routesconfirmed duplicate route registrations before the fix.