fix for when integrations_path is outside app/#78
Merged
JonPurvis merged 2 commits intosaloonphp:v3from Mar 8, 2026
Merged
Conversation
Sammyjo20
approved these changes
Mar 8, 2026
Member
Sammyjo20
left a comment
There was a problem hiding this comment.
Thanks for the fix @JonPurvis! There's one PHPStan gremlin, once this is resolved feel free to tag.
Collaborator
Author
|
Gremlin banished! I'll get a new patch release tagged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes saloonphp/saloon#476
When
integrations_pathis set to a path outsideapp/(e.g.base_path('src/Domains/Integrations')), thesaloon:connectorand other make commands were still writing files underapp/, producing paths likeapp/src/Domains/Integrations/...instead ofsrc/Domains/Integrations/....The namespace was correctly derived from
integrations_pathviagetNamespaceFromIntegrationsPath(), but the file path was always built from$this->laravel['path']in Laravel’sGeneratorCommand::getPath().Override
getPath()inMakeCommandso that when the class’s relative path starts with the segment from the configuredintegrations_path, the destination path is built fromconfig('saloon.integrations_path')instead of the app path. Default config (app/Http/Integrations) is unchanged.