Skip to content

retry via connector when rate limit sleep follows manual exceed #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JonPurvis wants to merge 2 commits into
base: v2
Choose a base branch
from
+5 −2
Open

retry via connector when rate limit sleep follows manual exceed #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8845cd3
retry via connector when rate limit sleep follows manual exceed
JonPurvis Mar 22, 2026
cc7e2f3
rerun tests
JonPurvis Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Traits/HasRateLimits.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,18 @@ public function bootHasRateLimits(PendingRequest $pendingRequest): void
// place. We should make sure to throw the exception here.

if (isset($limitThatWasExceeded)) {
if (! $limit->getShouldSleep()) {
if (! $limitThatWasExceeded->getShouldSleep()) {
$this->throwLimitException($limitThatWasExceeded);
}

// When the limit has been instructed to sleep() we will make the request
// again, which will trigger the request middleware to sleep, and then
// hopefully get a successful response afterward.
//
// Always delegate to the connector: send() exists on Connector but not on Request
// (see saloonphp/saloon#532).

return $this->send($response->getRequest());
return $response->getConnector()->send($response->getRequest());
}

return $response;
Expand Down
Loading