Skip to content

Pin openssl to LTS version #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwoz merged 1 commit into from
Mar 12, 2026
Merged

Pin openssl to LTS version #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions relenv/python-versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,9 @@
}
},
"openssl": {
"3.6.1": {
"3.5.5": {
"url": "https://github.com/openssl/openssl/releases/download/openssl-{version}/openssl-{version}.tar.gz",
"sha256": "b1bfedcd5b289ff22aee87c9d600f515767ebf45f77168cb6d64f231f518a82e",
"sha256": "b28c91532a8b65a1f983b4c28b7488174e4a01008e29ce8e69bd789f28bc2a89",
"platforms": [
"linux",
"darwin",
Expand Down
9 changes: 9 additions & 0 deletions relenv/pyversions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,10 @@ def verify_signature(
VERSION = None # '3.13.2'
UPDATE = False

PINNED_VERSIONS = {
"openssl": "3.5",
}


def digest(file: str | os.PathLike[str]) -> str:
"""
Expand Down Expand Up @@ -249,6 +253,11 @@ def detect_openssl_versions() -> list[str]:
# Find tags like openssl-3.5.4
pattern = r'openssl-(\d+\.\d+\.\d+)"'
matches = re.findall(pattern, content)

pin = PINNED_VERSIONS.get("openssl")
if pin:
matches = [v for v in matches if v == pin or v.startswith(f"{pin}.")]

# Deduplicate and sort
versions = sorted(
set(matches), key=lambda v: [int(x) for x in v.split(".")], reverse=True
Expand Down
24 changes: 21 additions & 3 deletions tests/test_pyversions_runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ def test_detect_openssl_versions(monkeypatch: pytest.MonkeyPatch) -> None:
"""Test OpenSSL version detection from GitHub releases."""
mock_html = """
<html>
<a href="/openssl/openssl/releases/tag/openssl-3.6.1">openssl-3.6.1</a>
<a href="/openssl/openssl/releases/tag/openssl-3.5.4">openssl-3.5.4</a>
<a href="/openssl/openssl/releases/tag/openssl-3.5.3">openssl-3.5.3</a>
<a href="/openssl/openssl/releases/tag/openssl-3.4.0">openssl-3.4.0</a>
Expand All @@ -120,14 +121,31 @@ def fake_fetch(url: str) -> str:
return mock_html

monkeypatch.setattr(pyversions, "fetch_url_content", fake_fetch)

# Test with pin "3.5" (current setting)
monkeypatch.setitem(pyversions.PINNED_VERSIONS, "openssl", "3.5")
versions = pyversions.detect_openssl_versions()
assert isinstance(versions, list)
assert "3.5.4" in versions
assert "3.5.3" in versions
assert "3.4.0" in versions
# Verify sorting (latest first)
assert "3.6.1" not in versions
assert "3.4.0" not in versions
assert versions[0] == "3.5.4"

# Test with different pin
monkeypatch.setitem(pyversions.PINNED_VERSIONS, "openssl", "3.4")
versions = pyversions.detect_openssl_versions()
assert "3.4.0" in versions
assert "3.5.4" not in versions
assert "3.6.1" not in versions

# Test with no pin
monkeypatch.delitem(pyversions.PINNED_VERSIONS, "openssl")
versions = pyversions.detect_openssl_versions()
assert "3.6.1" in versions
assert "3.5.4" in versions
assert "3.4.0" in versions
assert versions[0] == "3.6.1"


def test_detect_sqlite_versions(monkeypatch: pytest.MonkeyPatch) -> None:
"""Test SQLite version detection from sqlite.org."""
Expand Down
Loading