Fixes support for syslog when salt is running as non-root user#68801
Open
shadow38 wants to merge 1 commit intosaltstack:masterfrom
Open
Fixes support for syslog when salt is running as non-root user#68801shadow38 wants to merge 1 commit intosaltstack:masterfrom
shadow38 wants to merge 1 commit intosaltstack:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Same as #62263
The documented way to write to syslog is to use the config: log_file: file:///dev/log.
This breaks in some circumstances when running as non-root, for example, when log_level: info is set. In that case, /dev/log is not "writeable", so the code falls back to writing to /root/.salt/master.log, which is definitely not writeable by the non-root user salt is configured to run as.
This is an improved version of the original PR #62263. This PR uses an improved syslog path parser to manage all variant of syslog path supported by salt (file and tcp / udp connection). This function is mainly based on the salt source code. (see salt._logging.impl#setup_logfile_handler)
This version should work on any os.
What issues does this PR fix or reference?
Likely also fixes: #61286
Previous Behavior
Salt will try and write logs to /root/.salt/master.log, which is inaccessible when running as non-root, which means salt-master crashes out with a permissions error.
New Behavior
salt-master starts correctly.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No