Harden release artifact gates#39
Conversation
Signed-off-by: Mir Sameer <mirsameer0304@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac005bfb6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (summary.unavailable.length > 0) { | ||
| shouldFail = true; |
There was a problem hiding this comment.
Use a fully authorized token before failing closed
When this release gate runs in .github/workflows/release.yml, it is still passed ${{ github.token }} with only security-events: read; GitHub's workflow permission docs say security-events covers code-scanning alerts, Dependabot requires vulnerability-alerts: read, and secret-scanning alerts require a GitHub App or PAT. Because this new branch now fails on any 403/404 unavailable endpoint, tag releases will exit 1 on the Dependabot or secret-scanning checks even when there are no actionable alerts, blocking publishing rather than verifying the alert state.
Useful? React with 👍 / 👎.
Summary
Validation