Relax sequel and sqlite3 runtime dependency bounds#225
Open
CyJimmy264 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR relaxes Timetrap's runtime dependency constraints for
sequelandsqlite3:sequel:~> 5.90.0->>= 5.90, < 6sqlite3:~> 1.4->>= 1.4, < 3Why
The main motivation is downstream distro packaging.
I am packaging Timetrap as a dependency for QTimetrap, a desktop UI for Timetrap:
https://github.com/CyJimmy264/qtimetrap
On current Fedora, the packaged versions are newer than the currently allowed bounds:
sequel5.100.xsqlite32.xWith the existing constraints, downstream packagers have to create and maintain compatibility packages for older gem versions even if Timetrap itself works correctly with newer releases.
Relaxing the bounds makes Timetrap easier to package and distribute in system package repositories, while still keeping the major-version guardrails in place.
Validation
I validated this change locally with:
sequel 5.102.0sqlite3 2.9.2Checks performed:
gem build timetrap.gemspecsucceedsNotes
I could not run the full RSpec suite in this environment because
fakefsfails during spec boot on Ruby 3.4. That appears unrelated to this dependency change.If needed, I can also add a small compatibility note to the changelog or help test against any additional version combinations.