Fix OS detection w/ 'uname' on non-Linux systems#65
Open
ernstki wants to merge 1 commit intosampson-chen:masterfrom
Open
Fix OS detection w/ 'uname' on non-Linux systems#65ernstki wants to merge 1 commit intosampson-chen:masterfrom
ernstki wants to merge 1 commit intosampson-chen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit ed8a3b6 broke OS detection on non-Linux OSes, because
$CYGWIN_NTexpands to nothing when the environment variableCYGWIN_NTis undefined.What @DookTibs meant was just
"$sack__OS == "CYGWIN_NT"*(no dollar sign). It still worked under Cygwin, but just by luck, because$sack__OS == *. Addingset -u/set -o nounsetat the top of the script would stop these kinds of errors from slipping through, but that's a problem for another day.This PR should fix that problem, and makes OS detection work again on (at least) macOS.