Open
Conversation
Owner
|
I appreciate the PR. The challenge with this adjustment is the amount of time it will take to complete. I suppose now that there are callbacks, it's not as big of a deal, but anyone depending on the main function to return is going to have to wait orders of magnitude longer and it already takes a minute or so where this will now take hours. If we can increase the speed significantly I'd be open to an adjustment like this. It was much faster using img tags, however that was not cross-browser and removing the img tag or changing the src didn't seem to kill the connection, where fetch() is able to be aborted properly. |
samyk
added a commit
that referenced
this pull request
Nov 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some subnets are not found, so with
192.168.*.*its can looking for all possible subnet.Maybe this can be more complex but can found more results.