fixed globalposition offset in some scenarios#31
Closed
Kernvirus wants to merge 2 commits into
Closed
Conversation
Owner
|
Thank you for opening a PR. I'll take a look at it as soon as possible. In the meantime, could you please remove the files in the "lfs/objects" folder? |
Contributor
|
done |
Contributor
|
any update? I need this merged for my own project to continue. |
Owner
|
I'll have some time this weekend to look at it in detail. |
Owner
|
Continued in #33 |
Owner
|
Changes included in v5.0.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GlobalPosition should always be at min + size / 2 so that as a developer I can always get the minimum and maxium bounds of an imported voxel file.
This should always be true:
model.GlobalPos - floor(model.Size / 2) >= voxel.GlobalPosmodel.GlobalPos + ceil(model.Size / 2) < voxel.GlobalPosThis PR ensures this.
The problem is caused by insane way magica voxel handles rotations. When it rotates a model with an uneven size, it will add an invisible correction to the pivot to keep the center voxel in the same place before and after rotation. This results in of-by-one issues with the global pivot.
I sidestepped this issue by recalculating the global pivot by applying the transformation to the min and max voxel.