Y25-483 - Show Lot information using the v2 API#652
Y25-483 - Show Lot information using the v2 API#652
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #652 +/- ##
===========================================
+ Coverage 80.31% 81.45% +1.13%
===========================================
Files 74 75 +1
Lines 1128 1197 +69
===========================================
+ Hits 906 975 +69
Misses 222 222
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
StephenHulme
left a comment
StephenHulme
left a comment
There was a problem hiding this comment.
Thanks for the change :)
StephenHulme
left a comment
StephenHulme
left a comment
There was a problem hiding this comment.
Wrote the review, but forgot to submit it 🙈 - looks good but a couple questions.
| assert_select '#pending_plate_7 > .plate_barcode', 'DN8' | ||
| assert_select '#pending_plate_7 > .plate_barcode', 'DN8C' |
There was a problem hiding this comment.
This is an interesting change, what happened to the C?
There was a problem hiding this comment.
Not sure, it was just different to the others 👀
|
|
||
| setup do | ||
| mock_api | ||
| @lot_v1 = api.lot.find('11111111-2222-3333-4444-555555555556') |
There was a problem hiding this comment.
I don't think we should be using v1 if we can avoid it. Should be v2 compatible now.
| end | ||
| end | ||
|
|
||
| class Presenter::LotListTest < ActiveSupport::TestCase |
There was a problem hiding this comment.
Should be in a separate file.
|
|
||
| setup do | ||
| mock_api | ||
| @qcable_v1 = api.qcable.find('11111111-2222-3333-4444-100000000001') |
| end | ||
| end | ||
|
|
||
| class Presenter::UserTest < ActiveSupport::TestCase |
| end | ||
| end | ||
|
|
||
| class Presenter::Tag2LayoutTemplateTest < ActiveSupport::TestCase |
3 participants
Closes #563
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version