chore(pre-commit): update typos hook version#16
Merged
sangshuduo merged 2 commits intomainfrom Apr 17, 2025
Merged
Conversation
Owner
sangshuduo
commented
Apr 17, 2025
- Updated the version of the typos hook from v1.28.1 to v1.
- This change simplifies the versioning to the latest release.
- Ensures that we are using the most recent features and fixes available.
- Update the `typos` hook in the `.pre-commit-config.yaml` file - Change the `rev` value from `v1.26.0` to `v1.28.1`
- Updated the version of the typos hook from v1.28.1 to v1. - This change simplifies the versioning to the latest release. - Ensures that we are using the most recent features and fixes available.
Contributor
|
I'm getting to work. See my steps and track my cost here.
|
Contributor
There was a problem hiding this comment.
This is a straightforward update to the pre-commit configuration that changes the typos hook version from a specific version (v1.26.0) to just the major version (v1).
Benefits:
- Simplifies version management
- Automatically picks up new features and bug fixes within the v1.x line
- Reduces the need for frequent version updates in the configuration
Considerations:
- Using
v1makes builds slightly less deterministic compared to pinning a specific version - However, this is generally acceptable for development tools like pre-commit hooks when the tool follows semantic versioning (which typos does)
The change looks good to me. Similar versioning strategies are used for the other hooks in this file (like pre-commit-hooks at v5.0.0). This approach strikes a good balance between staying up-to-date and maintaining stability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.