Skip to content

chore(cli-test): exclude node_modules on Windows and tolerate dangling symlinks #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gu-stav wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(cli-test): exclude node_modules on Windows and tolerate dangling symlinks #1127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a64133f
chore(cli-test): exclude node_modules on Windows and tolerate danglin…
gu-stav May 22, 2026
489a86a
chore(cli-test): tighten targetStats type
gu-stav May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@sanity/cli-test/scripts/copy-fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

// eslint-disable-next-line n/no-unsupported-features/node-builtins
import {cp, mkdir, readFile, writeFile} from 'node:fs/promises'
import {dirname, join, resolve} from 'node:path'
import {basename, dirname, join, resolve} from 'node:path'

import {parse as parseYaml} from 'yaml'

Expand Down Expand Up @@ -89,7 +89,7 @@ async function copyFixtures() {
// Copy the fixture, excluding node_modules, .turbo and (unless specified) dist directories
await cp(sourceDir, targetDir, {
filter: (src) => {
const name = src.split('/').pop()
const name = basename(src)
return (
name !== 'node_modules' &&
name !== '.turbo' &&
Expand Down
16 changes: 14 additions & 2 deletions packages/@sanity/cli-test/src/test/testFixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,20 @@ export async function testFixture(
const srcPath = join(srcNodeModules, entry.name)
// Follow symlinks (e.g. pnpm's `node_modules/<pkg>` → `.pnpm/...`) so
// they get a 'dir' type on Windows — a file-typed symlink to a directory
// throws EPERM on stat.
const targetStats = entry.isSymbolicLink() ? await stat(srcPath) : entry
// throws EPERM on stat. Skip dangling symlinks: stat throws ENOENT when
// the target is missing (can happen with cross-OS turbo cache replay
// where Windows-absolute symlink targets don't resolve on Linux).
let targetStats: {isDirectory: () => boolean}
if (entry.isSymbolicLink()) {
try {
targetStats = await stat(srcPath)
} catch (err) {
if (err instanceof Error && 'code' in err && err.code === 'ENOENT') continue
throw err
}
} else {
targetStats = entry
}
await symlink(
srcPath,
join(destNodeModules, entry.name),
Expand Down
Loading