Split catalog fixes nojax#43
Open
talonmyburgh wants to merge 45 commits intomasterfrom
Open
Conversation
Pull in changes from master
Bring in corrections made in patch_no_sources
wip: split kronicle_payload
…full info for a computation product
fix(kronicle_rims_Schema.py): RimsObservationPayload
fix(kronicle_rims_schema.py): adjustments
Add rims publishing functionality and cli changes
…blem reading <blah>.ms: Missing Data colname FAKE_DATA
…egarding excluding targets due to radius
Custom Directory + Single MS: drops the files precisely into OutDirName Custom Directory + Multiple MSs: detects the multiple MS states and automatically creates safe subdirectories inside OutDirName #32
…n setting stokes=I or IQ or Q vs standard as have to collect half the correlation products. Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Fixes issues #32 #33 #34
Also fixed to calculate the randomly generated off targets using a
CoordMachine(as suggested by @cyriltasse). There is also some debug so that if targets in thesrclistare outside therad, a message mentions this.Finally, there is now a
--stokesparameter that takes in a str ("I", "IV", "IQUV" etc). This is quite a performance bump (saving ~30-40% of time and RAM) when the dataset was not calibrated for polarisation (currently the state intronpipeline). Naturally if parameters U or V are specified, the performance bump goes away as we then need all correlation products. If ignored this parameter defaults to "IQUV".PS. In making the stokes parameter upgrade, the saved FITS files are also smaller for subsets of IQUV. But this does mean they are non-standard - i.e. ds9 and casa will be angry - however inspect-dynspec is developed to handle these subsets correctly.