feat: implement missing Token2022Program extensions#3
Merged
jpe7s merged 2 commits intosava-software:mainfrom Mar 31, 2026
Merged
feat: implement missing Token2022Program extensions#3jpe7s merged 2 commits intosava-software:mainfrom
jpe7s merged 2 commits intosava-software:mainfrom
Conversation
Contributor
MetaverseMan
commented
Mar 30, 2026
- Add support for MetadataPointerExtension
- Add support for TransferHookExtension
- Implement initializeTokenMetadataInstruction per spl-token-metadata-interface
- Add support for MetadataPointerExtension - Add support for TransferHookExtension - Implement initializeTokenMetadataInstruction per spl-token-metadata-interface
jpe7s
reviewed
Mar 30, 2026
Member
jpe7s
left a comment
There was a problem hiding this comment.
Just a few nits. Can you grab a known working instruction for each type and create tests to validate that these serialize to the same bytes?
solana-programs/src/main/java/software/sava/solana/programs/token/Token2022Program.java
Outdated
Show resolved
Hide resolved
solana-programs/src/main/java/software/sava/solana/programs/token/Token2022Program.java
Show resolved
Hide resolved
solana-programs/src/main/java/software/sava/solana/programs/token/Token2022Program.java
Outdated
Show resolved
Hide resolved
Member
|
Will need to do some additional review and fix the remaining nits before releasing. Do you need this back-ported to Java 21? If not, I don't intend to as it is a feature and not a fix. |
Contributor
Author
Thanks for merging! No need to back-port to Java 21, it's fine to keep it only on newer versions. |
Member
|
Thank you @MetaverseMan for the PR. Published your contribution in version 25.0.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.