Always merge project files before external JARs (fixes #513)#571
Merged
Conversation
JAR entries are always read using forward slashes, while project files on Windows use backslashes
Previously order depended on exportJars flag: * false (default) - project files were ordered before external JAR dependencies * true - project files were packaged in JAR and ordered like an external dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for #513, comprised of three separate changes:
\instead of/) were masked byPathList.unapplySeq, but still passed to JarJarexportJars- scripted tests in merging/merging were run with explicitexportJars = true, but Windows paths were incorrectly processed only whenexportJars = false- I wanted to reuse this test, especially that merge order of project files and external JAR dependencies wasn't tested