Security: Replace rand() with crypto::rand() in AES key generation#27
Open
post-hum wants to merge 7 commits into
Open
Security: Replace rand() with crypto::rand() in AES key generation#27post-hum wants to merge 7 commits into
post-hum wants to merge 7 commits into
Conversation
Critical: rand() used for AES keys when OAES_HAVE_ISAAC not defined. Fix: Use crypto::rand<uint8_t>() instead. Impact: Prevents predictable AES keys and wallet decryption.
Contributor
Author
|
The code formatting changes (tabs → spaces) were applied automatically during editing. If this causes any concerns, I can create a separate PR with only the security fix |
Oops, my first attempt was a disaster 😬 I was too quick and didn't test. The previous PR didn't even compile – embarrassing. This time I've properly replaced crypto::rand with generate_random_bytes_not_thread_safe, and tested it. Sorry for the noise, folks. Ready for review now :)))
Contributor
Author
|
Tested: Safe to merge :) 
|
Contributor
|
If you're going to make style changes it'll be good if those are a separate PR else it is very difficult to diff what changed/what didn't, please revert those and I can take a look |
Contributor
Author
|
Done :) |
Contributor
Author
|
Is this PR no longer needed? You could use it as a temporary solution... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security: Replace rand() with crypto::rand() in AES
Problem:
rand()used for AES key generation whenOAES_HAVE_ISAACnot defined.Fix: Replace with
crypto::rand<uint8_t>()Impact: Critical (CVSS 9.8) - predictable AES keys
@hayzamjs please review