Skip to content

feat: enable apache expires module for caching assets #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ps-20x wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: enable apache expires module for caching assets #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion post-install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ add_apache_remoteip_config() {

awk '
$0 ~ /^# SPIN_APACHE_REMOTEIP_BLOCK$/ {
print "RUN a2enmod remoteip headers"
Copy link
Copy Markdown
Owner

@schnetzi schnetzi Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope for this PR but should also adapt this if this is merged: serversideup/docker-php#667

print "RUN a2enmod remoteip headers expires"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding the expires module here makes the function add_apache_remoteip_config and the placeholder # SPIN_APACHE_REMOTEIP_BLOCK's names misleading, as they now handle more than just remoteip configuration. This can create confusion and impact maintainability. Consider refactoring this by renaming the function and placeholder to something more generic (e.g., configure_apache and SPIN_APACHE_CONFIG_BLOCK) and updating the log message on line 84 to reflect the change.

print "COPY ./.infrastructure/conf/apache/remoteip.conf /etc/apache2/conf-available/remoteip.conf"
print "RUN a2enconf remoteip"
next
Expand Down