Added enum for multiple device types including SciFi; using placeholder name for new device#73
Closed
calvinleng-science wants to merge 1 commit intomainfrom
Closed
Added enum for multiple device types including SciFi; using placeholder name for new device#73calvinleng-science wants to merge 1 commit intomainfrom
calvinleng-science wants to merge 1 commit intomainfrom
Conversation
…e SciWave for now
Contributor
|
Hmm what is the purpose of this? Ideally synapse should be a generic API and not presuppose anything about specific products of ours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added enum for device types. Currently includes SciFi and placeholder name SciWave for the signal generator device.
Changes
Testing
Build headstage and synapse-spike-detect with these changes.