Make CentOS ImageStream json actually based on CentOS containers

[daveol]

It seems something went wrong when creating the file imagestreams\nginx-centos.json since they point to the UBI images instead of the images produced based off CentOS Stream. This fixes that.

Summary by CodeRabbit

• Chores
  • Switched nginx ImageStream base images from UBI to CentOS Stream and updated source image references.
  • Renamed image tags from *-ubi* to *-el* (e.g., 1.26-ubi9 → 1.26-el9) and set the "latest" tag to 1.26-el9.
  • Renamed distro labels to "CentOS Stream 8/9/10"; CentOS Stream 8 now lists only 1.24.

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated nginx-centos ImageStream metadata: tag names and the latest pointer changed from *-ubi* to *-el*, image from references switched to CentOS Stream quay images, distribution labels renamed from “UBI” to “CentOS Stream”, and CentOS Stream 8’s app_versions list reduced to ["1.24"].

Changes

Cohort / File(s)	Summary
ImageStream manifest imagestreams/imagestreams.yaml	Changed nginx-centos.json latest from 1.26-ubi9 → 1.26-el9; renamed distro entries UBI 8/9/10 → CentOS Stream 8/9/10; updated CentOS Stream 8 app_versions from ["1.22","1.24"] → ["1.24"].
ImageStream tags & sources imagestreams/nginx-centos.json	Replaced tag names *-ubi* → *-el*; updated annotations.openshift.io/display-name and description to “CentOS Stream” wording; switched tag from image references from registry.access.redhat.com/ubi*/nginx-* to quay.io/sclorg/nginx-*-c*s:latest; updated latest tag from to 1.26-el9.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I hopped through tags and gave a cheer,

UBI signs swapped for Stream so clear.
From -ubi- to -el- I pranced about,
Updated sources, stamped them stout.
A tiny hop — nginx streams, new route!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: converting the CentOS ImageStream from pointing to UBI containers to actually using CentOS Stream containers, which aligns with the actual file modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Pull Request validation

Failed

🔴 Failed or pending statuses:

• CodeRabbit[pending]

🔴 Review - Missing review from a member (1 required)

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@imagestreams/imagestreams.yaml`:
- Around line 18-19: The imagestreams.yaml entry for "CentOS Stream 8" declares
app_versions: ["1.22", "1.24"] but there is no corresponding build (no
1.22/Dockerfile.c8s), which results in an unresolved image tag like
quay.io/sclorg/nginx-122-c8s:latest; either remove "1.22" from the app_versions
array for the CentOS Stream 8 entry in imagestreams.yaml, or add the missing
1.22 build definition (e.g., create the 1.22/Dockerfile.c8s and related build
metadata) so that the nginx-centos.json quay tag resolves correctly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 79ea335c-167f-4d79-ba3b-66bda66354ac

📥 Commits

Reviewing files that changed from the base of the PR and between 9fed065 and 2876e2b.

📒 Files selected for processing (2)

• imagestreams/imagestreams.yaml
• imagestreams/nginx-centos.json

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

imagestreams/nginx-centos.json (1)

1-147: ⚠️ Potential issue | 🔴 Critical

Update tests and verify image availability on Quay.io.

Tests in test/test_ocp_shared_helm_imagestreams.py (lines 26-33) still reference old UBI tag names (e.g., 1.26-ubi10, 1.24-ubi9) and registry.redhat.io instead of the new el* tags and quay.io/sclorg references.

Additionally, the images referenced in nginx-centos.json have availability issues:

• quay.io/sclorg/nginx-120-c9s:latest returns 404 (image does not exist)
• quay.io/sclorg/nginx-122-c9s:latest returns 401 (access denied)
• quay.io/sclorg/nginx-126-c9s:latest returns 401 (access denied)

Update the test parameters to match the new tag scheme and ensure all referenced images are published and accessible on Quay.io.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@imagestreams/nginx-centos.json` around lines 1 - 147, Tests still reference
old UBI tags and registry names and the imagestream references contain
unavailable Quay images; update test/test_ocp_shared_helm_imagestreams.py to use
the new tag scheme (replace occurrences like "1.26-ubi10", "1.24-ubi9" with
"1.26-el10", "1.24-el8"/"1.24-el9" as appropriate) and change registry.redhat.io
references to quay.io/sclorg, and then update imagestream data in
nginx-centos.json to only reference Quay images that are actually published
(replace or remove the failing names quay.io/sclorg/nginx-120-c9s:latest,
quay.io/sclorg/nginx-122-c9s:latest, quay.io/sclorg/nginx-126-c9s:latest with
available tags such as the matching el* images or point to the correct
ImageStreamTag entries like "1.26-el9"/"1.26-el10"), and verify each image URL
via an HTTP HEAD/curl request or Quay API before committing.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@imagestreams/nginx-centos.json`:
- Around line 1-147: Tests still reference old UBI tags and registry names and
the imagestream references contain unavailable Quay images; update
test/test_ocp_shared_helm_imagestreams.py to use the new tag scheme (replace
occurrences like "1.26-ubi10", "1.24-ubi9" with "1.26-el10",
"1.24-el8"/"1.24-el9" as appropriate) and change registry.redhat.io references
to quay.io/sclorg, and then update imagestream data in nginx-centos.json to only
reference Quay images that are actually published (replace or remove the failing
names quay.io/sclorg/nginx-120-c9s:latest, quay.io/sclorg/nginx-122-c9s:latest,
quay.io/sclorg/nginx-126-c9s:latest with available tags such as the matching el*
images or point to the correct ImageStreamTag entries like
"1.26-el9"/"1.26-el10"), and verify each image URL via an HTTP HEAD/curl request
or Quay API before committing.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5beb7055-17b0-4e9f-b874-164a98fadd10

📥 Commits

Reviewing files that changed from the base of the PR and between 2876e2b and 822e715.

📒 Files selected for processing (2)

• imagestreams/imagestreams.yaml
• imagestreams/nginx-centos.json

🚧 Files skipped from review as they are similar to previous changes (1)

• imagestreams/imagestreams.yaml