Conversation
|
|
||
| // Since chromes implementation of the popup is dumb, we can't position | ||
| // it correctly without javascript. | ||
| if (!navigator.userAgent.toLowerCase().includes("firefox")) { |
There was a problem hiding this comment.
Is there a reason you removed this guard? As far as I could tell, only chrome was too dumb to do this.
There was a problem hiding this comment.
Yeah, I believe it is not needed anymore as I removed position: absolute from #menu. The popup appears at the correct location both on mobile and on desktop.
desktop:
mobile
There was a problem hiding this comment.
It wasn't needed to begin with. I just didn't want to meddle with default browser behaviour where I could, I think 🤔 Like the comment above mentions, firefox doesn't require the code at all to work correctly. I assume this would still be the case?
There was a problem hiding this comment.
I'm not sure I'm following. I removed the chrome-specific (or, rather, any non-firefox browser) guard because it wasn't required anymore as with the updated code the menu appears correctly on both chrome and firefox.
There was a problem hiding this comment.
The point was, that chrome NEEDED the code and firefox didn't. Maybe I wasn't clear.
Chrome with the toggle listener removed:
Firefox with the toggle listener removed:
However, it seems that there's now a way to achieve this WITHOUT Javascript.
I will try :)
There was a problem hiding this comment.
Here, if you are interested: a40b07a
I will merge in a separate PR to save you applying that stuff
|
I'd say the menu button container should also be the same height as the other two elements, looks a little weird otherwise. It's also a bit weird that the container for the word disappears after the game and isn't there before the game, but only in mobile mode 🤔 
|
Fixed both 
|
|
The history was messed up ... i merged manually using diffs. |
|
I deployed the changes :) Gonna wait for a release again if there's any bug report. |
2 participants
Closes #356
Showing the length of the word(s) after the word hint. It correctly handles RTL wordpacks and words with whitespaces (see images).
Note that it required to show the hint on a separate line on mobile to ensure there is enough space.
English wordpack with a whitespace, desktop
English wordpack with a whitespace, mobile
English wordpack, mobile
Longest word in the english wordpack, mobile 😄
Hebrew (RTL) wordpack with a whitespace, desktop
Hebrew (RTL) wordpack with a whitespace, mobile
