Closed
Conversation
* consitent component height in lobby creation elements > This broke the transitions, but its worth it * delete obsolete styling that didn't do anything * delete random inconsistent spacing * rename `MAX_CUSTOM_WORDS_PER_TURN` to `MAX_WORDS_PER_TURN` * max word per turn and custom words per turn now have the same upper bound, which is 6 by default * max words per turn must be greater or equal to custom words per turn * max words per turn can now be changed mid-game * remove incorrect percentage symbol when changing lobby settings * add title / alt to language flag * fix loss of scoring choice when inputting an incorrect value
Member
Author
|
Meh, github useless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #405 with my changes on top!