Skip to content

Conversation

@catreedle
Copy link
Collaborator

Contributor checklist


Description

  • Fix confirmDownload in SelectionViewTemplateController
  • Delete duplicated Nav Controller for InstallationVC in AppScreen.storyboard

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review January 15, 2026 20:27
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Just checked and all's working very well here, @catreedle 😊 Amazing work deducing the bug, making the issue and solving the problem! Thanks for your efforts :) :)

@andrewtavis andrewtavis merged commit f330f0b into scribe-org:main Jan 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navigation stack duplication between Download Language and Translation Source Settings

2 participants