ENA Driver: Remove invalid ring size alignment logic#7
Open
talawahtech wants to merge 1 commit intoscylladb:local-19.05from
Open
ENA Driver: Remove invalid ring size alignment logic#7talawahtech wants to merge 1 commit intoscylladb:local-19.05from
talawahtech wants to merge 1 commit intoscylladb:local-19.05from
Conversation
The previous logic was invalid. The RTE_ETH_DEV_FALLBACK_RX_RINGSIZE (and the TX counterpart) are values that rte_eth_rx_queue_setup() will set if dev_info.default_rxportconf.ring_size is 0 and user provided 0 in nb_rx_desc argument. However the current code treats it as a hint for the PMD to change the ring size to internal defaults. Backported from DPDK/dpdk@30a6c7ef4054.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a backport of a fix for the ENA driver that was added in v21.05. Without this fix Seastar/DPDK apps can't run on AWS EC2 instances unless the default ring size is changed.
The previous logic was invalid. The RTE_ETH_DEV_FALLBACK_RX_RINGSIZE (and the TX counterpart) are values
that rte_eth_rx_queue_setup() will set if dev_info.default_rxportconf.ring_size is 0 and user provided 0 in nb_rx_desc argument. However the current code treats it as a hint for the PMD to change the ring size to internal defaults.