Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

add param to paginate#320

Open
elha14 wants to merge 3 commits into
sdispater:0.9from
elha14:add_param_on_paginate
Open

add param to paginate#320
elha14 wants to merge 3 commits into
sdispater:0.9from
elha14:add_param_on_paginate

Conversation

@elha14
Copy link
Copy Markdown

@elha14 elha14 commented Aug 19, 2019

In case when we need to paginate we will do count query, when i need to select all column the count will use all column to, in my experience its not effective because in count we can just use 1 column
So i add column_count param in paginate, the param use to select which column that will be used in count query

Comment thread orator/orm/builder.py Outdated
Comment thread orator/query/builder.py Outdated
@mandarvaze
Copy link
Copy Markdown

Can you add tests ?

@elha14
Copy link
Copy Markdown
Author

elha14 commented Nov 25, 2019

Can you add tests ?

i already move my new param to last param in next commit
for test, i will do it later

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants