This repository was archived by the owner on May 14, 2024. It is now read-only.
add param to paginate#320
Open
elha14 wants to merge 3 commits into
Open
Conversation
added 2 commits
August 19, 2019 14:31
mandarvaze
reviewed
Nov 19, 2019
mandarvaze
reviewed
Nov 19, 2019
|
Can you add tests ? |
Author
i already move my new param to last param in next commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case when we need to
paginatewe will docountquery, when i need toselectall column thecountwill use all column to, in my experience its not effective because incountwe can just use 1 columnSo i add
column_countparam inpaginate, the param use to select which column that will be used incountquery