feat: allow moderators on opt-in roles#405
Open
herpaderpaldent wants to merge 2 commits into
Open
Conversation
- Add setModerator() to OptInRoleService (same pattern as ManualRoleService/OnRequestRoleService) - Update SetModeratorAction::validateRoleType() to accept OptInRoleService Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ated during SSO Previously throw_if() raised an exception causing a 500 on the initial SSO callback when a user was already logged in. Now we redirect to '/' silently, keeping the user where they should be. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opt-in roles previously could not have moderators — the
SetModeratorActionand the web controllers blocked the operation with a 403. This PR extends moderator support to opt-in roles.Changes
OptInRoleService::setModerator()— new method, identical pattern toManualRoleService/OnRequestRoleService: callssetRoleMembership()withcan_moderateflagSetModeratorAction::validateRoleType()— updated to also acceptOptInRoleServiceTests
All 278 tests pass, 100% type coverage maintained.