feat: integrate seatplus/esi-schema — DTOs from esi-schema, direct DTO returns#23
Merged
herpaderpaldent merged 1 commit intoMay 11, 2026
Conversation
… endpoints - Require seatplus/esi-schema:1.x-dev (VCS from github.com/seatplus/esi-schema) - Delete src/Generated/Responses/ — all DTOs now come from seatplus/esi-schema - Generator: no longer generates DTO files, only Resources - Generator: all DTO imports changed to Seatplus\EsiSchema\Responses\* - Object endpoints (single-object responses) now return the DTO directly instead of wrapping in EsiResult<T>. The DTO extends AbstractEsiDto so $dto->isCachedLoad and $dto->pages are available on the result. - Paginated array endpoints keep EsiResult<array<T>> (pages metadata required) - Update tests to reflect new return types - Update README: compatibility date notice + new SDK usage examples - ESI compatibility date: 2025-12-16 and forward Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Merged directly into #22. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates seatplus/esi-schema as the source of truth for all ESI response DTOs and changes object-endpoint methods to return DTOs directly instead of wrapping them in
EsiResult<T>.What changed
seatplus/esi-schemadependency"seatplus/esi-schema": "1.x-dev"+ VCS repository tocomposer.jsonsrc/Generated/Responses/deleted (218 files removed) — all DTOs now come from esi-schemaGenerator (
bin/generate.php)usestatements changed toSeatplus\EsiSchema\Responses\*Resource return types
getAlliancesAllianceId)EsiResult<AllianceDetail>AllianceDetailgetCharactersCharacterIdAssets)EsiResult<array<T>>EsiResult<array<T>>(unchanged)EsiResult<T>EsiResult<T>(unchanged)Object DTOs extend
AbstractEsiDtoso$dto->isCachedLoadand$dto->pagesare available directly on the returned DTO:README
Added ESI compatibility date notice:
Quality gates