feat: add RoleDetail read-only view with affiliations, members, and moderators#1486
Open
herpaderpaldent wants to merge 1 commit into
Open
feat: add RoleDetail read-only view with affiliations, members, and moderators#1486herpaderpaldent wants to merge 1 commit into
herpaderpaldent wants to merge 1 commit into
Conversation
…tors ShowControlGroupController now passes role.members (all user memberships with status + can_moderate flag) and role.moderators (users with can_moderate=true) alongside the existing affiliations and permissions. RoleDetail.vue replaces the 13-line stub with a full read-only detail page: - PageHeader with breadcrumb back to /acl and Edit button (can_edit) - Role info card: name, type badge, description, permissions list - Affiliations section: entity cards via EntityByIdBlock + affiliation_type badge - Moderators section (when present): user cards with main_character - Members section: user cards with status badge (active/inactive/pending) and Moderator badge for can_moderate members ShowControlGroupControllerTest updated to assert role.members and role.moderators are present in the Inertia response. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PR Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
RoleDetailpage — a read-only detail view for ACL roles, showing:Changes
Backend
ShowControlGroupController— eager-loadsrole_memberships.entity.main_character; now passesrole.members(all user memberships with status/can_moderate/user) androle.moderators(users withcan_moderate=true)ShowControlGroupControllerTest— assertsrole.membersandrole.moderatorsare present in the Inertia responseFrontend
resources/js/Pages/AccessControl/RoleDetail.vue— full read-only detail page (replaces 13-line stub)PageHeader,EntityByIdBlock,EntityBlock,EveImagefrom SharedDepends on
PR #1485 (Wayfinder migration) must merge first.