feat(i18n): add Estonian language support#2611
feat(i18n): add Estonian language support#2611Sym-jay wants to merge 1 commit intoseerr-team:developfrom
Conversation
📝 WalkthroughWalkthroughAdds Estonian locale support: inserts Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gauthier-th
left a comment
There was a problem hiding this comment.
You forgot to add the new language to src/context/LanguageContext.tsx and src/pages/_app.tsx
e0d7499 to
0ddf374
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/pages/_app.tsx`:
- Around line 49-50: The switch in src/pages/_app.tsx includes a case 'et' that
dynamically imports '../i18n/locale/et.json', but that file is missing; either
add a new JSON file at src/i18n/locale/et.json containing the Estonian
translations (matching the shape of the other locale files) or remove the case
'et' from the switch in _app.tsx so the code does not attempt the failing
dynamic import; ensure whichever path you choose keeps the switch/default
behavior consistent with other locales.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
server/api/tvdb/interfaces.tsserver/types/languages.d.tssrc/context/LanguageContext.tsxsrc/pages/_app.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
- server/api/tvdb/interfaces.ts
Overview
Adds Estonian language support infrastructure to the application.
Changes
Note
This PR removes the translation file per maintainer feedback. Translations should be managed through Weblate to avoid breaking the translation workflow.
Summary by CodeRabbit