Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/cliff.toml:
- Line 89: The skip rule "{ message = '.*\\(helm\\).*', skip = true }" is placed
after the grouping commit_parsers so it never matches; move this helm skip rule
to appear before the grouping rules in the commit_parsers array so it gets
evaluated first (ensuring commits like "feat(helm): ..." are skipped) and keep
the rest of the grouping rules (the ^feat, ^fix, etc.) following it.
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
582d08a to
83f8bb2
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/cliff.toml:
- Around line 73-74: The TOML strings for the regex entries { message =
"^chore\(release\): prepare for", skip = true } and { message =
"^chore\(deps.*\)", skip = true } use invalid escape sequences (\( and \))
inside double-quoted strings; change each to either single-quoted literal
strings (e.g. message = '^chore\(release\): prepare for') or double-escape the
backslashes in the existing double quotes (e.g. message = "^chore\\(release\\):
prepare for") so the TOML parser accepts the regexes.
- Around line 75-77: The security parser { body = ".*security", group = "<!-- 0
-->🛡️ Security" } is listed before the type-specific parsers and will match
first, overriding commits that should be grouped by message patterns like {
message = "^feat", group = "<!-- 1 -->🚀 Features" } and { message = "^fix",
group = "<!-- 2 -->🐛 Bug Fixes" }; reorder the entries so the message-based
parsers (the "^feat" and "^fix" rules) appear before the body-based security
rule to ensure type-specific grouping wins, leaving the security rule lower in
the list to only catch leftover commits mentioning "security".
Description
Ignore helm scope in git-cliff so we can use whatever conventional commit "type".
Refactored a bit the config to drop unused config.
How Has This Been Tested?
Screenshots / Logs (if applicable)
Checklist:
pnpm buildpnpm i18n:extractSummary by CodeRabbit